Skip to content

Format application web resources with Spotless#10023

Open
ruibaby wants to merge 1 commit into
halo-dev:mainfrom
ruibaby:improvement/spotless-web-resources
Open

Format application web resources with Spotless#10023
ruibaby wants to merge 1 commit into
halo-dev:mainfrom
ruibaby:improvement/spotless-web-resources

Conversation

@ruibaby
Copy link
Copy Markdown
Member

@ruibaby ruibaby commented May 21, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds a Spotless webResources format in the application module for server-rendered web assets:

  • src/main/resources/templates/**/*.html
  • src/main/resources/static/styles/**/*.css
  • src/main/resources/static/js/**/*.js

The formatter uses Prettier with shared tabWidth and printWidth settings, letting Prettier infer the parser from each file extension. This keeps template, CSS, and JavaScript formatting checks under the owning application module instead of the repository root.

This PR also applies the formatter to the existing application web resources.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Validated with:

./gradlew :application:spotlessWebResourcesCheck spotlessCheck

AI-assisted contribution: OpenAI Codex was used to help inspect the existing Spotless configuration, update the Gradle setup, run validation, and prepare this PR.

Does this PR introduce a user-facing change?

NONE

@f2c-ci-robot f2c-ci-robot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 21, 2026
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby marked this pull request as ready for review May 21, 2026 16:06
@f2c-ci-robot f2c-ci-robot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.03%. Comparing base (42c374d) to head (9d8919e).
⚠️ Report is 588 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10023      +/-   ##
============================================
+ Coverage     59.55%   61.03%   +1.48%     
- Complexity     3812     4091     +279     
============================================
  Files           677      706      +29     
  Lines         23248    23772     +524     
  Branches       1500     1564      +64     
============================================
+ Hits          13846    14510     +664     
+ Misses         8764     8515     -249     
- Partials        638      747     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant