-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Fix the repeat registration with the email already verified #7323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the repeat registration with the email already verified #7323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug that allowed repeat registrations with an email that has already been verified by enforcing a check for duplicate verified emails.
- Added a new exception (EmailAlreadyTakenException) to indicate a duplicate verified email.
- Updated the signUp method in UserServiceImpl to verify the email and prevent duplicate registrations.
- Introduced new test coverage in UserServiceImplTest to ensure the fix works correctly.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
application/src/test/java/run/halo/app/core/user/service/impl/UserServiceImplTest.java | Added a test to verify that a duplicate email triggers the EmailAlreadyTakenException. |
application/src/main/java/run/halo/app/security/preauth/PreAuthSignUpEndpoint.java | Updated error handling in the sign-up endpoint to properly handle the duplicate email scenario. |
application/src/main/java/run/halo/app/infra/exception/EmailAlreadyTakenException.java | Introduced a new exception class to represent the duplicate verified email error. |
application/src/main/java/run/halo/app/core/user/service/impl/UserServiceImpl.java | Modified signUp logic to check for duplicate verified emails and set email verification status accordingly; added a helper method checkEmailAlreadyVerified. |
api/src/main/java/run/halo/app/core/user/service/UserService.java | Updated interface to include the new checkEmailAlreadyVerified method. |
Files not reviewed (2)
- application/src/main/resources/config/i18n/messages.properties: Language not supported
- application/src/main/resources/config/i18n/messages_zh.properties: Language not supported
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7323 +/- ##
============================================
+ Coverage 57.18% 57.50% +0.32%
- Complexity 4066 4100 +34
============================================
Files 721 722 +1
Lines 24546 24609 +63
Branches 1612 1621 +9
============================================
+ Hits 14036 14151 +115
+ Misses 9882 9818 -64
- Partials 628 640 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR fixes the repeat registration with the email already verified.
Which issue(s) this PR fixes:
Fixes #7308
Does this PR introduce a user-facing change?