Skip to content

Fix the repeat registration with the email already verified #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR fixes the repeat registration with the email already verified.

Screenshot From 2025-04-02 16-33-22

Which issue(s) this PR fixes:

Fixes #7308

Does this PR introduce a user-facing change?

修复注册时未验证邮箱是否已被占用的问题

@JohnNiang JohnNiang requested a review from Copilot April 2, 2025 08:50
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby April 2, 2025 08:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug that allowed repeat registrations with an email that has already been verified by enforcing a check for duplicate verified emails.

  • Added a new exception (EmailAlreadyTakenException) to indicate a duplicate verified email.
  • Updated the signUp method in UserServiceImpl to verify the email and prevent duplicate registrations.
  • Introduced new test coverage in UserServiceImplTest to ensure the fix works correctly.

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
application/src/test/java/run/halo/app/core/user/service/impl/UserServiceImplTest.java Added a test to verify that a duplicate email triggers the EmailAlreadyTakenException.
application/src/main/java/run/halo/app/security/preauth/PreAuthSignUpEndpoint.java Updated error handling in the sign-up endpoint to properly handle the duplicate email scenario.
application/src/main/java/run/halo/app/infra/exception/EmailAlreadyTakenException.java Introduced a new exception class to represent the duplicate verified email error.
application/src/main/java/run/halo/app/core/user/service/impl/UserServiceImpl.java Modified signUp logic to check for duplicate verified emails and set email verification status accordingly; added a helper method checkEmailAlreadyVerified.
api/src/main/java/run/halo/app/core/user/service/UserService.java Updated interface to include the new checkEmailAlreadyVerified method.
Files not reviewed (2)
  • application/src/main/resources/config/i18n/messages.properties: Language not supported
  • application/src/main/resources/config/i18n/messages_zh.properties: Language not supported

Copy link

sonarqubecloud bot commented Apr 2, 2025

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.50%. Comparing base (60c2009) to head (5b05b54).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...lo/app/security/preauth/PreAuthSignUpEndpoint.java 0.00% 4 Missing ⚠️
...lo/app/core/user/service/impl/UserServiceImpl.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7323      +/-   ##
============================================
+ Coverage     57.18%   57.50%   +0.32%     
- Complexity     4066     4100      +34     
============================================
  Files           721      722       +1     
  Lines         24546    24609      +63     
  Branches       1612     1621       +9     
============================================
+ Hits          14036    14151     +115     
+ Misses         9882     9818      -64     
- Partials        628      640      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
Copy link

f2c-ci-robot bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit fb7a097 into halo-dev:main Apr 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

同一个邮箱可以重复注册[已开启注册需验证邮箱]
2 participants