Skip to content

fix: resolve editor styling issues in Safari browser #7328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 7, 2025

What type of PR is this?

/kind bug
/area editor
/area ui
/milestone 2.20.x

What this PR does / why we need it:

Replace drop-shadow-* with shadow-* to resolve editor styling issues in Safari brower.

before:

image image

after:

image image

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复编辑器在 Safari 浏览器中关于浮动工具栏和命令列表的样式问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 7, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Apr 7, 2025
@f2c-ci-robot f2c-ci-robot bot added area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI labels Apr 7, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen April 7, 2025 15:15
Copy link

sonarqubecloud bot commented Apr 7, 2025

Copy link

pkg-pr-new bot commented Apr 7, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7328

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7328

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7328

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7328

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7328

commit: 4dbf671

@ruibaby ruibaby requested a review from Copilot April 7, 2025 15:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • ui/packages/editor/src/styles/base.scss: Language not supported

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (60c2009) to head (4dbf671).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7328      +/-   ##
============================================
+ Coverage     57.18%   57.50%   +0.32%     
- Complexity     4066     4100      +34     
============================================
  Files           721      722       +1     
  Lines         24546    24609      +63     
  Branches       1612     1621       +9     
============================================
+ Hits          14036    14151     +115     
+ Misses         9882     9818      -64     
- Partials        628      640      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
Copy link

f2c-ci-robot bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 629a0f8 into halo-dev:main Apr 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants