-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
fix: resolve editor styling issues in Safari browser #7328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ryan Wang <[email protected]>
|
@halo-dev/api-client
@halo-dev/components
@halo-dev/console-shared
@halo-dev/ui-plugin-bundler-kit
@halo-dev/richtext-editor
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- ui/packages/editor/src/styles/base.scss: Language not supported
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7328 +/- ##
============================================
+ Coverage 57.18% 57.50% +0.32%
- Complexity 4066 4100 +34
============================================
Files 721 722 +1
Lines 24546 24609 +63
Branches 1612 1621 +9
============================================
+ Hits 14036 14151 +115
+ Misses 9882 9818 -64
- Partials 628 640 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area editor
/area ui
/milestone 2.20.x
What this PR does / why we need it:
Replace
drop-shadow-*
withshadow-*
to resolve editor styling issues in Safari brower.before:
after:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?