Skip to content

Extract PAT operation with service #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR refactors UserScopedPatHandlerImpl with PAT service to make PAT operations flexible.

Does this PR introduce a user-facing change?

None

@JohnNiang JohnNiang requested a review from Copilot April 14, 2025 08:58
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Apr 14, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Apr 14, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 14, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

application/src/main/java/run/halo/app/core/user/service/impl/PatServiceImpl.java:246

  • [nitpick] Consider extracting the hardcoded 'pat_' prefix into a constant to ensure consistency with other components and to ease future modifications.
return Mono.just(jwt).map(jwt -> "pat_" + jwt.getTokenValue());

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 51.79856% with 67 lines in your changes missing coverage. Please review.

Project coverage is 57.47%. Comparing base (60c2009) to head (2e4f04a).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...alo/app/core/user/service/impl/PatServiceImpl.java 50.86% 49 Missing and 8 partials ⚠️
...y/authentication/pat/UserScopedPatHandlerImpl.java 56.52% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7341      +/-   ##
============================================
+ Coverage     57.18%   57.47%   +0.28%     
- Complexity     4066     4107      +41     
============================================
  Files           721      723       +2     
  Lines         24546    24670     +124     
  Branches       1612     1634      +22     
============================================
+ Hits          14036    14178     +142     
+ Misses         9882     9842      -40     
- Partials        628      650      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby April 14, 2025 09:13
@JohnNiang JohnNiang force-pushed the refactor/pat-service branch from 1ee50d3 to 2e4f04a Compare April 14, 2025 09:48
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
Copy link

f2c-ci-robot bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 3a5e4f8 into halo-dev:main Apr 14, 2025
9 checks passed
@JohnNiang JohnNiang deleted the refactor/pat-service branch April 14, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants