-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Extract PAT operation with service #7341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
application/src/main/java/run/halo/app/core/user/service/impl/PatServiceImpl.java:246
- [nitpick] Consider extracting the hardcoded 'pat_' prefix into a constant to ensure consistency with other components and to ease future modifications.
return Mono.just(jwt).map(jwt -> "pat_" + jwt.getTokenValue());
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7341 +/- ##
============================================
+ Coverage 57.18% 57.47% +0.28%
- Complexity 4066 4107 +41
============================================
Files 721 723 +2
Lines 24546 24670 +124
Branches 1612 1634 +22
============================================
+ Hits 14036 14178 +142
+ Misses 9882 9842 -40
- Partials 628 650 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ee50d3
to
2e4f04a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR refactors UserScopedPatHandlerImpl with PAT service to make PAT operations flexible.
Does this PR introduce a user-facing change?