Skip to content

fix: resolve issue with categoryName parameter not working in postFinder.list() #7350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

chengzhongxue
Copy link
Contributor

@chengzhongxue chengzhongxue commented Apr 16, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复 postFinder.list() 传参 categoryName 查询不到子类文章

Which issue(s) this PR fixes:

Fixes #7296

Does this PR introduce a user-facing change?

修复 postFinder.list() 的 categoryName 参数无效的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 16, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang April 16, 2025 13:30
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.47%. Comparing base (60c2009) to head (709d8e5).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7350      +/-   ##
============================================
+ Coverage     57.18%   57.47%   +0.29%     
- Complexity     4066     4107      +41     
============================================
  Files           721      723       +2     
  Lines         24546    24667     +121     
  Branches       1612     1633      +21     
============================================
+ Hits          14036    14178     +142     
+ Misses         9882     9840      -42     
- Partials        628      649      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby ruibaby changed the title fix: postFinder.list() passes the categoryName parameter to query the subclass article fix: resolve issue with categoryName parameter not working in postFinder.list() Apr 18, 2025
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 18, 2025
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2025
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

/approve

Copy link

f2c-ci-robot bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 9225668 into halo-dev:main Apr 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postFinder.list categoryName 参数查询不到子类文章
3 participants