Skip to content

Comments

Support impersonating other users for super admin#7351

Merged
f2c-ci-robot[bot] merged 2 commits intohalo-dev:mainfrom
JohnNiang:feat/impersonate
Apr 20, 2025
Merged

Support impersonating other users for super admin#7351
f2c-ci-robot[bot] merged 2 commits intohalo-dev:mainfrom
JohnNiang:feat/impersonate

Conversation

@JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Apr 16, 2025

What type of PR is this?

/kind feature
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR adds support for impersonating other users for super admin.

  1. Login as super admin
  2. Request POST /login/impersonate?username=xxx and the current user should be xxx
  3. Request POST /logout/impersonate and the current user should be super admin

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 16, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Apr 16, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/core Issues or PRs related to the Halo Core labels Apr 16, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen April 16, 2025 14:13
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.51%. Comparing base (60c2009) to head (d1a6e2a).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...rity/HaloRedirectAuthenticationSuccessHandler.java 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7351      +/-   ##
============================================
+ Coverage     57.18%   57.51%   +0.33%     
- Complexity     4066     4113      +47     
============================================
  Files           721      725       +4     
  Lines         24546    24696     +150     
  Branches       1612     1635      +23     
============================================
+ Hits          14036    14204     +168     
+ Misses         9882     9841      -41     
- Partials        628      651      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JohnNiang JohnNiang changed the title WIP: Support impersonating other users for super admin Support impersonating other users for super admin Apr 18, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2025
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2025
@sonarqubecloud
Copy link

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 20, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit e0b9c50 into halo-dev:main Apr 20, 2025
9 checks passed
@JohnNiang JohnNiang deleted the feat/impersonate branch May 4, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants