Skip to content

Support impersonating other users for super admin #7351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Apr 16, 2025

What type of PR is this?

/kind feature
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR adds support for impersonating other users for super admin.

  1. Login as super admin
  2. Request POST /login/impersonate?username=xxx and the current user should be xxx
  3. Request POST /logout/impersonate and the current user should be super admin

Does this PR introduce a user-facing change?

支持超级管理员切换用户身份

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 16, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Apr 16, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/core Issues or PRs related to the Halo Core labels Apr 16, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen April 16, 2025 14:13
Copy link

f2c-ci-robot bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from johnniang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.50%. Comparing base (60c2009) to head (c2e3c3b).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...rity/HaloRedirectAuthenticationSuccessHandler.java 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7351      +/-   ##
============================================
+ Coverage     57.18%   57.50%   +0.32%     
- Complexity     4066     4113      +47     
============================================
  Files           721      725       +4     
  Lines         24546    24699     +153     
  Branches       1612     1636      +24     
============================================
+ Hits          14036    14204     +168     
+ Misses         9882     9843      -39     
- Partials        628      652      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JohnNiang JohnNiang changed the title WIP: Support impersonating other users for super admin Support impersonating other users for super admin Apr 18, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant