Skip to content

WIP: refactor: improve entity component layout for better device responsiveness #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 24, 2025

What type of PR is this?

/area ui
/kind improvement

What this PR does / why we need it:

Refactor Entity-related components to better adapt to different devices.

Note: It should be noted that the current solution includes breaking updates, and if the plugin uses this component, it needs to be adapted. Although this change will not cause functional problems, it will only affect the style. This is just an attempt at the moment, I will also try other solutions to ensure compatibility

before:

image

after:

Screen.Recording.2025-04-24.at.16.52.26.mov

Which issue(s) this PR fixes:

Fixes #7360
Fixes #7357
Fixes #5483
Fixes #2699
Fixes #7130
Fixes #7393

Special notes for your reviewer:

Does this PR introduce a user-facing change?

优化 Console 和 UC 中数据列表的 UI 在不同尺寸设备下的表现

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen April 24, 2025 08:55
Copy link

f2c-ci-robot bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ruibaby. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

pkg-pr-new bot commented Apr 24, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7383

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7383

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7383

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7383

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7383

commit: 477aae8

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.41%. Comparing base (60c2009) to head (477aae8).
Report is 28 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7383      +/-   ##
============================================
+ Coverage     57.18%   59.41%   +2.23%     
- Complexity     4066     4114      +48     
============================================
  Files           721      696      -25     
  Lines         24546    23937     -609     
  Branches       1612     1548      -64     
============================================
+ Hits          14036    14223     +187     
+ Misses         9882     9061     -821     
- Partials        628      653      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby ruibaby changed the title refactor: improve entity component layout for better device responsiveness WIP: refactor: improve entity component layout for better device responsiveness Apr 24, 2025
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues or PRs related to the Halo UI do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
1 participant