Skip to content

Conversation

@LIlGG
Copy link
Member

@LIlGG LIlGG commented Jan 5, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

在渲染评论 HTML 及保存 HTML 内容时允许包含相对路径的图片。

这是评论支持上传媒体文件的相关 PR。

see halo-dev/plugin-comment-widget#205

Does this PR introduce a user-facing change?

None

Preserves relative links in comment service and allows 'img' tags and 'class' attribute on 'code' tags in comment content rendering. Improves flexibility for displaying user-generated content with syntax highlighting and images.
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 5, 2026
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilgg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.07%. Comparing base (42c374d) to head (1f194de).
⚠️ Report is 381 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8177      +/-   ##
============================================
+ Coverage     59.55%   61.07%   +1.51%     
- Complexity     3812     3991     +179     
============================================
  Files           677      695      +18     
  Lines         23248    23766     +518     
  Branches       1500     1550      +50     
============================================
+ Hits          13846    14514     +668     
+ Misses         8764     8512     -252     
- Partials        638      740     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LIlGG added 4 commits January 6, 2026 15:54
Updated CommentContentConverter tests to mock and verify ExternalLinkProcessor instead of ExternalUrlSupplier. This aligns the tests with recent changes in link processing logic and ensures correct handling of relative and absolute image links.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant