-
Notifications
You must be signed in to change notification settings - Fork 10.2k
feat: allow saving and rendering of HTML with relative path images #8177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preserves relative links in comment service and allows 'img' tags and 'class' attribute on 'code' tags in comment content rendering. Improves flexibility for displaying user-generated content with syntax highlighting and images.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8177 +/- ##
============================================
+ Coverage 59.55% 61.07% +1.51%
- Complexity 3812 3991 +179
============================================
Files 677 695 +18
Lines 23248 23766 +518
Branches 1500 1550 +50
============================================
+ Hits 13846 14514 +668
+ Misses 8764 8512 -252
- Partials 638 740 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…port-comment-media
Updated CommentContentConverter tests to mock and verify ExternalLinkProcessor instead of ExternalUrlSupplier. This aligns the tests with recent changes in link processing logic and ensures correct handling of relative and absolute image links.
|



What type of PR is this?
/kind feature
What this PR does / why we need it:
在渲染评论 HTML 及保存 HTML 内容时允许包含相对路径的图片。
这是评论支持上传媒体文件的相关 PR。
see halo-dev/plugin-comment-widget#205
Does this PR introduce a user-facing change?