Refactor plugin management to use SpringPluginManager and improve started plugins retrieval #8181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted plugins retrieval
f2c-ci-robot
bot
added
kind/bug
f2c-ci-robot
bot
added
area/core
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area core
/area plugin
/milestone 2.22.x
What this PR does / why we need it:
This PR factors plugin management to use SringPluginManager and improve started plugins retrieval to make sure the plugin inside started plugins starts exactly.
We cannot directly override the original
getStartedPluginsmethod due to internal use and modification on start.Which issue(s) this PR fixes:
Fixes #8164
Special notes for your reviewer
stopmethodDoes this PR introduce a user-facing change?