Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only query the necessary applications when checking updates #13

Merged
merged 2 commits into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions console/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"dayjs": "^1.11.9",
"github-markdown-css": "^5.2.0",
"pretty-bytes": "^6.1.1",
"qs": "^6.11.2",
"semver": "^7.5.4",
"vue": "^3.3.4",
"vue-i18n": "^9.2.2"
Expand Down
17 changes: 10 additions & 7 deletions console/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 4 additions & 20 deletions console/src/composables/use-app-compare.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { AppType, STORE_APP_ID } from "@/constant";
import type { ApplicationSearchResult } from "@/types";
import type { Plugin, PluginList, Theme, ThemeList } from "@halo-dev/api-client";
import { useQuery } from "@tanstack/vue-query";
import axios from "axios";
import { computed, type Ref } from "vue";
import semver from "semver";
import { useHaloVersion } from "./use-halo-version";
import { useFetchInstalledPlugins } from "./use-plugin";
import { useFetchInstalledThemes } from "./use-theme";

export function useAppCompare(app: Ref<ApplicationSearchResult | undefined>) {
const { haloVersion } = useHaloVersion();
Expand All @@ -14,23 +13,8 @@ export function useAppCompare(app: Ref<ApplicationSearchResult | undefined>) {
return app.value?.application.spec.type;
});

const { data: installedPlugins } = useQuery<Plugin[]>({
queryKey: ["plugins"],
queryFn: async () => {
const { data } = await axios.get<PluginList>(`/apis/api.console.halo.run/v1alpha1/plugins`);
return data.items;
},
enabled: computed(() => appType.value === AppType.PLUGIN),
});

const { data: installedThemes } = useQuery<Theme[]>({
queryKey: ["themes"],
queryFn: async () => {
const { data } = await axios.get<ThemeList>("/apis/api.console.halo.run/v1alpha1/themes?uninstalled=false");
return data.items;
},
enabled: computed(() => appType.value === AppType.THEME),
});
const { installedPlugins } = useFetchInstalledPlugins(computed(() => appType.value === AppType.PLUGIN));
const { installedThemes } = useFetchInstalledThemes(computed(() => appType.value === AppType.THEME));

const matchedPlugin = computed(() => {
if (appType.value === AppType.PLUGIN) {
Expand Down
3 changes: 2 additions & 1 deletion console/src/composables/use-app-download.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,13 @@ export function useAppDownload(app: Ref<ApplicationSearchResult | undefined>) {
function handleClearQueryCache() {
if (appType.value === "THEME") {
queryClient.invalidateQueries({ queryKey: ["installed-themes"] });
queryClient.invalidateQueries({ queryKey: ["themes"] });
queryClient.invalidateQueries({ queryKey: ["store-installed-themes"] });
return;
}

if (appType.value === "PLUGIN") {
queryClient.invalidateQueries({ queryKey: ["plugins"] });
queryClient.invalidateQueries({ queryKey: ["store-installed-plugins"] });
}
}

Expand Down
10 changes: 8 additions & 2 deletions console/src/composables/use-plugin-version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,35 @@ import type { ApplicationSearchResult, ListResponse } from "@/types";
import storeApiClient from "@/utils/store-api-client";
import type { Plugin } from "@halo-dev/api-client";
import { useQuery } from "@tanstack/vue-query";
import { computed, type Ref } from "vue";
import { computed, ref, type Ref } from "vue";
import semver from "semver";
import { useHaloVersion } from "./use-halo-version";
import { STORE_APP_ID } from "@/constant";
import { useFetchInstalledPlugins } from "./use-plugin";

export function usePluginVersion(plugin: Ref<Plugin | undefined>) {
const { haloVersion } = useHaloVersion();

// TODO: 可能需要专门的最新版本应用列表接口
const { installedPlugins } = useFetchInstalledPlugins(ref(true));

const { data: storePlugins } = useQuery<ListResponse<ApplicationSearchResult>>({
queryKey: ["plugin-apps"],
queryFn: async () => {
const appIds = installedPlugins.value?.map((plugin) => plugin.metadata.annotations?.[STORE_APP_ID]) || [];

const { data } = await storeApiClient.get<ListResponse<ApplicationSearchResult>>(
`/apis/api.store.halo.run/v1alpha1/applications`,
{
params: {
type: "PLUGIN",
names: appIds,
},
}
);
return data;
},
staleTime: 1000,
enabled: computed(() => !!installedPlugins.value?.length),
});

const matchedApp = computed(() => {
Expand Down
20 changes: 20 additions & 0 deletions console/src/composables/use-plugin.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { STORE_APP_ID } from "@/constant";
import { apiClient } from "@/utils/api-client";
import type { Plugin } from "@halo-dev/api-client";
import { useQuery } from "@tanstack/vue-query";
import type { Ref } from "vue";

export function useFetchInstalledPlugins(enabled: Ref<boolean>) {
const { data: installedPlugins } = useQuery<Plugin[]>({
queryKey: ["store-installed-plugins"],
queryFn: async () => {
const { data } = await apiClient.plugin.listPlugins();
return data.items.filter((plugin) => {
return !!plugin.metadata.annotations?.[STORE_APP_ID];
});
},
enabled,
staleTime: 1000,
});
return { installedPlugins };
}
10 changes: 8 additions & 2 deletions console/src/composables/use-theme-version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,35 @@ import type { ApplicationSearchResult, ListResponse } from "@/types";
import storeApiClient from "@/utils/store-api-client";
import type { Theme } from "@halo-dev/api-client";
import { useQuery } from "@tanstack/vue-query";
import { computed, type Ref } from "vue";
import { computed, ref, type Ref } from "vue";
import semver from "semver";
import { useHaloVersion } from "./use-halo-version";
import { STORE_APP_ID } from "@/constant";
import { useFetchInstalledThemes } from "./use-theme";

export function useThemeVersion(theme: Ref<Theme | undefined>) {
const { haloVersion } = useHaloVersion();

// TODO: 可能需要专门的最新版本应用列表接口
const { installedThemes } = useFetchInstalledThemes(ref(true));

const { data: storeThemes } = useQuery<ListResponse<ApplicationSearchResult>>({
queryKey: ["theme-apps"],
queryFn: async () => {
const appIds = installedThemes.value?.map((theme) => theme.metadata.annotations?.[STORE_APP_ID]) || [];

const { data } = await storeApiClient.get<ListResponse<ApplicationSearchResult>>(
`/apis/api.store.halo.run/v1alpha1/applications`,
{
params: {
type: "THEME",
names: appIds,
},
}
);
return data;
},
staleTime: 1000,
enabled: computed(() => !!installedThemes.value?.length),
});

const matchedApp = computed(() => {
Expand Down
21 changes: 21 additions & 0 deletions console/src/composables/use-theme.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { STORE_APP_ID } from "@/constant";
import { apiClient } from "@/utils/api-client";
import type { Theme } from "@halo-dev/api-client";
import { useQuery } from "@tanstack/vue-query";
import type { Ref } from "vue";

export function useFetchInstalledThemes(enabled: Ref<boolean>) {
const { data: installedThemes } = useQuery<Theme[]>({
queryKey: ["store-installed-themes"],
queryFn: async () => {
const { data } = await apiClient.theme.listThemes({
uninstalled: false,
});
return data.items.filter((theme) => {
return !!theme.metadata.annotations?.[STORE_APP_ID];
});
},
enabled,
});
return { installedThemes };
}
4 changes: 4 additions & 0 deletions console/src/utils/store-api-client.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import axios from "axios";
import qs from "qs";

const storeApiClient = axios.create({
baseURL: import.meta.env.VITE_APP_STORE_BACKEND,
paramsSerializer: (params) => {
return qs.stringify(params, { arrayFormat: "repeat" });
},
});

export default storeApiClient;
Loading