Skip to content

fix: rendering issue due to missing default values #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 28, 2024

为验证码相关的配置添加默认值,以解决升级之后页面渲染异常的问题,需要注意,FormKit 的 group 类型不能只在其下输入框设置默认值,需要在 group 节点设置。

/kind bug

Fixes #137

修复缺失默认配置导致页面渲染异常的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang June 28, 2024 04:40
Copy link

f2c-ci-robot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ruibaby. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby requested a review from LIlGG June 28, 2024 04:40
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议撤销这些改动然后在

给定初始化为 CaptchaConfig.empty() 即可,原因是序列化时没有值不会走 set 方法,这里忘记写默认值导致的

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang merged commit ac73c90 into halo-dev:main Jun 28, 2024
3 of 4 checks passed
@ruibaby ruibaby deleted the fix/default-value branch June 28, 2024 16:19
ruibaby added a commit to ruibaby/plugin-comment-widget that referenced this pull request Aug 8, 2024
* fix: rendering issue due to missing default values

Signed-off-by: Ryan Wang <[email protected]>

* Set default values for captcha

Signed-off-by: Ryan Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

升级到最新版会导致文章页面 500
3 participants