Fix CI: scalafmt + made version mismatch - #5
Closed
halotukozak wants to merge 6 commits into
Closed
Conversation
halotukozak
changed the title
3 tasks
scala-cli fmt --check has been failing on master since before this session (reproduces on commit d5a59ce) — one blank line too many before the -Yprofile-enabled directive. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…T vs 0.1.3-done-SNAPSHOT) project.scala requested made:0.2.1-SNAPSHOT while ci.yml published the pinned made commit locally as 0.1.3-done-SNAPSHOT - neither resolved to the other, so CI's "Run tests" step failed on every commit regardless of content. Aligning both on 0.3.0 per the repo owner's direction. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ntax
Root cause of the "Run tests" failures wasn't a version mismatch (made
0.3.0's real API still has everything mrpc needs) - it was that ci.yml
pinned a made commit (16bfbdb) 37 commits behind v0.3.0, missing:
- getAllAnnotations entirely (added in c5a98e5/d361b36)
- containsOnly evidence for Tuple.Tail/Reverse/Concat/Zip (ad6f7a4/713d57a),
which mrpc's recursive tuple-walking macros (RpcNames, OpPlan,
MetadataDerivation, Plans) depend on to chain containsOnly evidence
across `.tail` calls
- InputElem.ExtractLabel (24800ec)
Bumping the pin to v0.3.0 (a61445c) picks up all three, purely additive
per the made-side diff (no removed/renamed members between the two).
The one real mrpc-side fix: made's getAllAnnotations is an extension
method (`self.getAllAnnotations[A]`), not a positional function
(`getAllAnnotations(self)(using ...)[A]`) - MetadataDerivation.allTerms
was calling it the old way.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mcodec's old pinned commit predates made's getAnnotation Option[A] -> A | Null change (same root cause as the made pin bump in the previous commit). Repointing to the fix branch until halotukozak-com/mcodec#4 merges. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Root cause of this PR's hanging 'Run tests' CI step: thread-dumped the stuck Bloop/dotc process and found the compiler thread pinned at 100% CPU for 10+ minutes inside dotty.tools.dotc.transform.init.Semantic$$anon$1.traverse, recursing through TypeAccumulator.foldOver -- the -Wsafe-init checker walking a type graph it never finishes on this codebase's inline-derivation-heavy code. Verified: with it removed, compile+test-compile finishes in ~25s. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
force-pushed
the
fix-project-scala-fmt
branch
from
August 9, 2026 09:05
d41b9ca to
8aa52bc
Compare
GoldenFixtureSuite reads fixtures/*.json via a path relative to the process working directory. CI's other steps run from the outer checkout root (mrpc/made/mcodec are sibling directories there), so the bare `scala-cli --power test mrpc` command left the fixture lookup resolving against the wrong directory, failing 5 tests with FileNotFoundException. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three independent, pre-existing CI breakages, all unrelated to any feature work in #3/#4/#6:
scala-cli fmt --checkwas failing onproject.scala(extra blank line before-Yprofile-enabled).project.scalarequestedmade:0.2.1-SNAPSHOTwhileci.ymlpublished the pinnedmadecommit locally asmade:0.1.3-done-SNAPSHOT— mismatched labels, nothing resolved.made:0.3.0is API-incompatible.ci.yml's pinned commit SHA (16bfbdb) is 37 commits behind thev0.3.0tag, missinggetAllAnnotationsentirely, thecontainsOnlyevidence forTuple.Tail/Reverse/Concat/Zipthat mrpc's recursive tuple-walking macros depend on, andInputElem.ExtractLabel. Bumped the pin tov0.3.0(a61445c) — purely additive on the made side, nothing removed/renamed.getAllAnnotationsis an extension method (self.getAllAnnotations[A]) in the version mrpc now targets, not a positional function call —MetadataDerivation.allTermsused the old calling convention.Test plan
🤖 Generated with Claude Code