Skip to content

Performance and Code Improvements - #158

Open
SujitSingh wants to merge 3 commits into
hampusborgos:mainfrom
SujitSingh:performance-and-code-improvements
Open

Performance and Code Improvements#158
SujitSingh wants to merge 3 commits into
hampusborgos:mainfrom
SujitSingh:performance-and-code-improvements

Conversation

@SujitSingh

Copy link
Copy Markdown

This PR is for improvements added for PNG generation feature.

Changes summary -

  • Using sharp for image export operations. Removed dependencies of svgexport, imagemin-cli and exec checks.
  • Removed necessity of temp-image generation
  • Code readability improvements. Though new changes have cameCase variable naming instead of snake_case.
  • Added sharp under dependencies of package.json
  • Using "type": "module" in package.json for using import rather than require.
  • Improvements to .gitignore file.
  • README file update.

Results -

  • Improved performance -> I think it is more than 10x fast but I haven't compared them using benchmarks.
  • Simpler and more readable code.
  • Single command for installing dependencies using just npm install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant