Remove card border #291
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ export default function ServerCard({ serverInfo }: { serverInfo: NezhaAPISafe }) | |
| <Link onClick={saveSession} href={`/server/${id}`} prefetch={true}> | ||
| <Card | ||
| className={cn( | ||
| "flex cursor-pointer flex-col items-center justify-start gap-3 p-3 transition-all hover:shadow-sm hover:ring-stone-300 md:px-5 dark:hover:ring-stone-700", | ||
|
There was a problem hiding this comment. [nitpick] The ServerCard hover effect removes the border hover but doesn't set an initial ring state. For consistency with ServerOverviewClient cards (lines 73, 106, 139) which use |
||
| { | ||
| "flex-col": fixedTopServerName, | ||
| "lg:flex-row": !fixedTopServerName, | ||
|
|
@@ -133,7 +133,7 @@ export default function ServerCard({ serverInfo }: { serverInfo: NezhaAPISafe }) | |
| <Link onClick={saveSession} href={`/server/${id}`} prefetch={true}> | ||
| <Card | ||
| className={cn( | ||
| "flex cursor-pointer flex-col items-center justify-start gap-3 p-3 transition-all hover:shadow-sm hover:ring-stone-300 md:px-5 dark:hover:ring-stone-700", | ||
|
There was a problem hiding this comment. [nitpick] The ServerCard hover effect removes the border hover but doesn't set an initial ring state. For consistency with ServerOverviewClient cards (lines 73, 106, 139) which use |
||
| showNetTransfer ? "min-h-[123px] lg:min-h-[91px]" : "min-h-[93px] lg:min-h-[61px]", | ||
| { | ||
| "flex-col": fixedTopServerName, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ export default function ServerCardInline({ serverInfo }: { serverInfo: NezhaAPIS | |
| <Link onClick={saveSession} href={`/server/${id}`} prefetch={true}> | ||
| <Card | ||
| className={cn( | ||
| "flex w-full min-w-[900px] cursor-pointer items-center justify-start gap-3 p-3 transition-all hover:shadow-sm hover:ring-stone-300 md:px-5 lg:flex-row dark:hover:ring-stone-700", | ||
|
There was a problem hiding this comment. [nitpick] The ServerCardInline hover effect removes the border hover but doesn't set an initial ring state. For consistency with ServerOverviewClient cards (lines 73, 106, 139) which use |
||
| )} | ||
| > | ||
| <section | ||
|
|
@@ -123,7 +123,7 @@ export default function ServerCardInline({ serverInfo }: { serverInfo: NezhaAPIS | |
| <Link onClick={saveSession} href={`/server/${id}`} prefetch={true}> | ||
| <Card | ||
| className={cn( | ||
| "flex min-h-[61px] min-w-[900px] flex-row items-center justify-start gap-3 p-3 transition-all hover:shadow-sm hover:ring-stone-300 md:px-5 lg:flex-row dark:hover:ring-stone-700", | ||
|
There was a problem hiding this comment. [nitpick] The ServerCardInline hover effect removes the border hover but doesn't set an initial ring state. For consistency with ServerOverviewClient cards (lines 73, 106, 139) which use |
||
| )} | ||
| > | ||
| <section | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -68,7 +68,7 @@ export function SignIn() { | |||||||||||||||||||||
| </label> | ||||||||||||||||||||||
| <button | ||||||||||||||||||||||
| type="submit" | ||||||||||||||||||||||
| className="flex w-fit cursor-pointer items-center gap-1 rounded-[8px] border border-stone-300 bg-card px-1.5 py-0.5 font-semibold text-card-foreground text-sm shadow-lg shadow-stone-200/50 transition-all hover:brightness-95 dark:border-stone-800 dark:shadow-none" | ||||||||||||||||||||||
|
There was a problem hiding this comment. Inconsistent shadow styling: The base Card component uses
Suggested change
There was a problem hiding this comment. Inconsistent shadow color: The shadow color changes from |
||||||||||||||||||||||
| disabled={loading} | ||||||||||||||||||||||
|
Comment on lines
69
to
72
There was a problem hiding this comment. Disabled submit button will still look clickable due to With - <button
- type="submit"
- className="flex w-fit cursor-pointer items-center gap-1 rounded-[8px] border border-stone-300 bg-card px-1.5 py-0.5 font-semibold text-card-foreground text-sm shadow-lg shadow-stone-200/50 transition-all hover:brightness-95 dark:border-stone-800 dark:shadow-none"
- disabled={loading}
- >
+ <button
+ type="submit"
+ className="flex w-fit items-center gap-1 rounded-[8px] border border-stone-300 bg-card px-1.5 py-0.5 font-semibold text-card-foreground text-sm shadow-lg shadow-stone-200/50 transition-all hover:brightness-95 disabled:cursor-not-allowed disabled:opacity-60 dark:border-stone-800 dark:shadow-none"
+ disabled={loading}
+ >📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||
| > | ||||||||||||||||||||||
| {t("Submit")} | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent ring removal: The "All" card removes
ring-transparentfrom the default state but the other cards (Online, Offline, Favorite) retainring-1with no explicit color. This creates an inconsistent visual appearance where the "All" card may have a visible ring by default (inheriting from the Card base component) while others havering-1. Consider either addingring-1to the "All" card or removingring-1from the other cards for consistency.