Herobrine1010 - #4
Open
herobrine1010 wants to merge 2 commits into
Open
Conversation
1. Denoised some character pictures. 2. Added "fall" sound for all characters and "dropped" sound for some characters. To make sure that "dropped" sound would not be covered, `soundPlaying.destroy()`(line 181 in file state.ts) is also commented out. The original code of the latest version reserving this function would interrupt any overlapping sound, thus making the design of "dropped" invalid. Actually, though not hanging up a clip before letting another start may bring about chaotic effect in terms of sound, I would still suggest doing so. Allowing the sound to overlap is also necessary for further updates on options such as background music. All clips are from bestdori.com, and the original clips seems too loud at volume=0.5. I altered it to 0.4. 3. Added corresponding voice clip of band name on clearing each group. "band-data.ts" is also added, which works like "character-data.ts". 4. Added Hagumi's croquette as falling item. 5. Added some image assets in path "./src/asset/objects" for future use, such as bands' logos, coronet-throwing Rimi and some else. These are not yet applied in this update.
1. Denoised some character pictures. 2. Added "fall" sound for all characters and "dropped" sound for some characters. To make sure that "dropped" sound would not be covered, `soundPlaying.destroy()`(line 181 in file state.ts) is also commented out. The original code of the latest version reserving this function would interrupt any overlapping sound, thus making the design of "dropped" invalid. Actually, though not hanging up a clip before letting another start may bring about chaotic effect in terms of sound, I would still suggest doing so. Allowing the sound to overlap is also necessary for further updates on options such as background music. All clips are from bestdori.com, and the original clips seems too loud at volume=0.5. I altered it to 0.4. 3. Added corresponding voice clip of band name on clearing each group. "band-data.ts" is also added, which works like "character-data.ts". 4. Added Hagumi's croquette as falling item. 5. Added some image assets in path "./src/asset/objects" for future use, such as bands' logos, coronet-throwing Rimi and some else. These are not yet applied in this update.
Owner
|
Hello Herobrine ! First of all , thank you for contributing to pazuru-pico. |
Author
|
Thanks for replying! There's some minor problems, I'll recommit as soon as I should get through it.
…------------------ 原始邮件 ------------------
发件人: "Tanyawat Vittayapalotai"<notifications@github.com>;
发送时间: 2020年10月27日(星期二) 晚上9:56
收件人: "hamzaabamboo/pazuru-pico"<pazuru-pico@noreply.github.com>;
抄送: "Herobrine L."<1374803733@qq.com>; "Author"<author@noreply.github.com>;
主题: Re: [hamzaabamboo/pazuru-pico] Herobrine1010 (#4)
Hello Herobrine ! First of all , thank you for contributing to pazuru-pico.
That's a lot of code and new assets right there !
I tried your code and I think it works really well.
Before merging, can you run the format script and make a commit again ?
using npm run format or yarn format
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Author
|
I tried the format script but found that there's always such an error. It seems irrelevant to the NPM version or the actual code, and I repulled the latest github version and the same error occurred on running "npm run format". The output is like this ⬇.
#path#\GitHub\pazuru-pico>yarn format
yarn run v1.22.4
$ prettier --write src
#path#\GitHub\pazuru-pico\node_modules\prettier\third-party.js:9871
for await (const place of this.config.searchPlaces) {
^^^^^
SyntaxError: Unexpected reserved word
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Module._compile (module.js:617:28)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Module.require (module.js:597:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (#path#\GitHub\pazuru-pico\node_modules\prettier\index.js:16561:18)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
If this is a indispensable procedure, I'm afraid that I'm not able to amend it and have to give up the commit. Anyway, thank you for reviewing and testing my pull request !
Happy! Lucky! Smile! Yeah! ≥w≤
…------------------ 原始邮件 ------------------
发件人: "hamzaabamboo/pazuru-pico" <notifications@github.com>;
发送时间: 2020年10月27日(星期二) 晚上9:56
收件人: "hamzaabamboo/pazuru-pico"<pazuru-pico@noreply.github.com>;
抄送: "Herobrine L."<1374803733@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [hamzaabamboo/pazuru-pico] Herobrine1010 (#4)
Hello Herobrine ! First of all , thank you for contributing to pazuru-pico.
That's a lot of code and new assets right there !
I tried your code and I think it works really well.
Before merging, can you run the format script and make a commit again ?
using npm run format or yarn format
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Owner
|
Sorry for late reply, I am kinda busy lately. |
Author
|
It's so kind of you!! Thanks a lot >w<
…------------------ 原始邮件 ------------------
发件人: "Tanyawat Vittayapalotai"<notifications@github.com>;
发送时间: 2020年11月3日(星期二) 下午3:09
收件人: "hamzaabamboo/pazuru-pico"<pazuru-pico@noreply.github.com>;
抄送: "Herobrine L."<1374803733@qq.com>; "Author"<author@noreply.github.com>;
主题: Re: [hamzaabamboo/pazuru-pico] Herobrine1010 (#4)
Sorry for late reply, I am kinda busy lately.
No problem for the formatting, I will sort it out after merge.
I'll merge this soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content of this update:
Denoised some character pictures.
Added "fall" sound for all characters and "dropped" sound for some characters. To make sure that "dropped" sound would not be covered,
soundPlaying.destroy()(line 181 in file state.ts) is also commented out. The original code of the latest version reserving this function would interrupt any overlapping sound, thus making the design of "dropped" invalid.Actually, though not hanging up a clip before letting another start may bring about chaotic effect in terms of sound, I would still suggest doing so. Allowing the sound to overlap is also necessary for further updates on options such as background music.
All clips are from bestdori, and the original clips seems too loud at volume=0.5. I altered it to 0.4.
Added corresponding voice clip of band name on clearing each group. "band-data.ts" is also added, which works like "character-data.ts".
Added Hagumi's croquette as falling item.
Added some image assets in path "./src/asset/objects" for future use, such as bands' logos, coronet-throwing Rimi and some else. These are not yet applied in this update.