-
-
Notifications
You must be signed in to change notification settings - Fork 35
Convert slice generator to use ruby class file #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cllns
wants to merge
39
commits into
main
Choose a base branch
from
convert-slice-generator-to-use-ruby-class-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up from #292
Without the leading strings, sometimes the slice starts with a number which is not a valid leading character in a Ruby constant
Just copied and modified from RubyClassFile. Need to refactor later
Also added logic to only generate it if dry-operation is bundled
Also refactored Hanami::CLI::Files private method dir_path (from _path) since it wasn't clear to me why we'd used one or the other, and it just adds a trailing file separator so this is a better name.
In preparation for removing it
…or-to-use-ruby-class-file
Simplifies what the children need to implement
And refactor specs a little
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of refactors here too:
RubyFile
, so nowRubyClassFile
andRubyModuleFile
are just thin subclasses with their specific behavior. Open to other approaches here. I considered just assuming everything is a class file, then having amodule:
boolean arg with different behavior, since we rarely ever need to generate modules.