-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate image comparison tests #27
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
===========================================
- Coverage 100.00% 94.50% -5.50%
===========================================
Files 17 17
Lines 844 855 +11
===========================================
- Hits 844 808 -36
- Misses 0 47 +47 ☔ View full report in Codecov by Sentry. |
I'm confused why the tests are now showing as uncovered |
@williamjameshandley rolling back codecov has fixed it 🥲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @AdamOrmondroyd
you're happy to roll back codecov? |
Yes. |
Disappointed, but not surprised |
Description
Spotted #6, so have reinstated the tests. Since then, it seems the$3.5\sigma$ contour doesn't plot any more, and the style of the line plots is a bit different. Comparison below:
Old
New
I realised that the "
no_ax
" tests should output the same as their "fig, ax = plt.subplots()
" counterparts, so they use the same images for comparisonFixes #6
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: