Skip to content

chain: add airstop soft fork #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rithvikvibhu
Copy link
Member

@rithvikvibhu rithvikvibhu commented Apr 19, 2025

This is a very simple PR to disable airdrops with a soft fork.

While it is currently functional and "works", everything is open to change (the name, scope, signalling threshold, duration, etc.)

It does not deal with name claims or non-airdrop faucet claims. It does not do any reallocation of funds. It only stops airdrops from being claimed if the soft fork is activated.

This should hopefully get some conversation going.

h/t to @nodech who wrote the icannlockup soft-fork, much of the test code is stolen from test/chain-icann-lockup-test.js

@coveralls
Copy link

coveralls commented Apr 19, 2025

Coverage Status

coverage: 71.307% (+0.04%) from 71.269%
when pulling 5dea694 on rithvikvibhu:end-airdrop
into 5f11d62 on handshake-org:master.

@AndreiChyrych
Copy link

«This is a very simple PR to disable airdrops with a soft fork»

is it possible to reintroduce airdrop with a new soft fork?

@Falci
Copy link
Member

Falci commented Apr 19, 2025

is it possible to reintroduce airdrop with a new soft fork?

No, that would require a hard fork.

@j9011303
Copy link

I support this proposal. Ending the airdrop makes sense at this stage of the project.
It can help reduce unnecessary token supply and move the project forward.

@smcki012
Copy link

My Father allows this. You can proceed.

@agaamin
Copy link

agaamin commented Apr 20, 2025

Lets do this.
Burn the damn spare tokens.

@smcki012

This comment was marked as abuse.

@HNSbroker
Copy link

Isn't there a way to actually burn the coins and permanently remove them from the supply, instead of just stopping the claims?

@Falci
Copy link
Member

Falci commented Apr 20, 2025

Isn't there a way to actually burn the coins and permanently remove them from the supply, instead of just stopping the claims?

These coins don't actually exist. The airdrop creates coins out of thin air when they're claimed. By stopping the airdrop, we prevent these coins from ever being created, removing them from the supply.

@faltrum
Copy link

faltrum commented Apr 20, 2025

Great Moment and great decision!. Congrats community involved in this step. Next steps:

  1. Ensure miners awareness
  2. Update the BIP9 dates
  3. Merge
  4. Wait the merge to be activated, or not.

Thanks @rithvikvibhu and @Falci for clarifications.

// Disable airdrop claims if
// - airstop is activated, and
// - this is an airdrop, not a faucet claim
if (state.hasAirstop && !proof.isAddress()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, the branch name is more descriptive than the version bit's name.
But I understand this has a bit of marketing/promotion/momentum attached to it as is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a placeholder name, I don't mind changing it

@rhymincymon
Copy link

I think this is the right way forward.

The supply looks as follows without and with the soft fork activated.

airdrop airstop

After the last subsidized block is mined, a total of 961,262,671.16 HNS would have been issued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants