-
Notifications
You must be signed in to change notification settings - Fork 290
chain: add airstop soft fork #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8bbef64
to
5dea694
Compare
«This is a very simple PR to disable airdrops with a soft fork» is it possible to reintroduce airdrop with a new soft fork? |
No, that would require a hard fork. |
I support this proposal. Ending the airdrop makes sense at this stage of the project. |
My Father allows this. You can proceed. |
Lets do this. |
This comment was marked as abuse.
This comment was marked as abuse.
Isn't there a way to actually burn the coins and permanently remove them from the supply, instead of just stopping the claims? |
These coins don't actually exist. The airdrop creates coins out of thin air when they're claimed. By stopping the airdrop, we prevent these coins from ever being created, removing them from the supply. |
Great Moment and great decision!. Congrats community involved in this step. Next steps:
Thanks @rithvikvibhu and @Falci for clarifications. |
// Disable airdrop claims if | ||
// - airstop is activated, and | ||
// - this is an airdrop, not a faucet claim | ||
if (state.hasAirstop && !proof.isAddress()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, the branch name is more descriptive than the version bit's name.
But I understand this has a bit of marketing/promotion/momentum attached to it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was just a placeholder name, I don't mind changing it
This is a very simple PR to disable airdrops with a soft fork.
While it is currently functional and "works", everything is open to change (the name, scope, signalling threshold, duration, etc.)
It does not deal with name claims or non-airdrop faucet claims. It does not do any reallocation of funds. It only stops airdrops from being claimed if the soft fork is activated.
This should hopefully get some conversation going.
h/t to @nodech who wrote the icannlockup soft-fork, much of the test code is stolen from
test/chain-icann-lockup-test.js