HF-160: ADDRESS drops the sheet separator when sheetName is empty - #1739
Open
marcin-kordas-hoc wants to merge 2 commits into
Open
HF-160: ADDRESS drops the sheet separator when sheetName is empty#1739marcin-kordas-hoc wants to merge 2 commits into
marcin-kordas-hoc wants to merge 2 commits into
Conversation
=ADDRESS(2,3,1,FALSE(),) returned '!R2C3' - the '!' separator was emitted for an empty-string sheet name. Excel returns 'R2C3'. One condition: an empty string no longer produces a sheet prefix, for both A1 and R1C1 styles; non-empty sheet names are untouched. Implemented by a prep-ship lane (task HF-160); the loop could not see its own green (harness path bug, prep-ship#1 follow-up) so verified here: authored spec 37/37, unit/interpreter 390 suites / 3531 tests green, tsc --noEmit clean, eslint clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PdHPZAjciZFWqGa19Yf7it
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
hyperformula-docs | 62cb944 | Commit Preview URL Branch Preview URL |
Aug 20 2026, 09:04 AM |
Performance comparison of head (62cb944) vs base (61ead73) |
marcin-kordas-hoc
marked this pull request as ready for review
August 18, 2026 05:49
Collaborator
Author
|
Paired tests PR: handsontable/hyperformula-tests#40 — merge it BEFORE this one. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PdHPZAjciZFWqGa19Yf7it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1739 +/- ##
========================================
Coverage 97.31% 97.31%
========================================
Files 195 195
Lines 15719 15719
Branches 3455 3384 -71
========================================
Hits 15297 15297
- Misses 414 422 +8
+ Partials 8 0 -8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes HF-160 (GH #1641):
=ADDRESS(2,3,1,FALSE(),)returned!R2C3— the sheet separator was emitted for an empty-string sheet name. Excel returnsR2C3.What changed
One condition in
AddressPlugin: an empty string no longer produces a sheet prefix, for both A1 and R1C1 styles. Non-empty sheet names keep producingSheet1!R2C3exactly as before.Verification
Paired tests:
hyperformula-tests@spike/hf160-address-sheetname(37 assertions: trailing-comma / explicit""/ omitted forms in both styles, non-empty names pinned unchanged). Fullunit/interpreter390 suites / 3531 tests green,tsc --noEmitclean,eslint --quietclean.🤖 Generated with Claude Code
Note
Low Risk
Single-condition change in ADDRESS string formatting; no auth, data, or broad API impact.
Overview
Fixes HF-160:
ADDRESSno longer emits a stray!when the optional sheet name is an empty string (e.g. trailing comma or explicit""), so R1C1 results match Excel (R2C3instead of!R2C3).The only code change is in
AddressPlugin: the sheet prefix is built only whensheetNameis defined, non-null, and non-empty. Non-empty names still produceSheet1!…as before.Reviewed by Cursor Bugbot for commit deb5b76. Bugbot is set up for automated code reviews on this repo. Configure here.