Fix package.json #250
Open
Fix package.json #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the package.json has no entry for `main`, it cannot be loaded by tools like webpack. Fix ng-handsontable not being able to be imported in webpack. Please merge and publish a minor update to npm
|
Hey @maritaria we no longer develop this project but as this is a small change we can make an exception. However, to allow us to merge your code you'd need to sign CLA document. It just allows us to pull the code. |
|
Honestly I dont want to sign this, it seems to burden me with
responsibilities I dont want to agree to on a whim. Its a lot of commitment
from me for a one line change. Copy it if accepting my change directly is
such a liability.
The fork on my account already suffices for a solution on my end.
Cheers
…On Tue, Aug 20, 2019, 11:10 Aleksandra Budnik ***@***.***> wrote:
Hey @maritaria <https://github.com/maritaria>
we no longer develop this project but as this is a small change we can
make an exception. However, to allow us to merge your code you'd need to
sign CLA document
<https://docs.google.com/forms/d/e/1FAIpQLScpMq4swMelvw3-onxC8Jl29m0fVp5hpf7d1yQVklqVjGjWGA/viewform?c=0&w=1>.
It just allows us to pull the code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#250?email_source=notifications&email_token=ABJ657KWG5LLTSQDW5LY26DQFOYGRA5CNFSM4INSHO22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4VTUQA#issuecomment-522926656>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJ657MOZIXTTMN7XXLRGSTQFOYGRANCNFSM4INSHO2Q>
.
|
|
I fully understand. I cannot force you to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the package.json has no entry for
main, it cannot be loaded by tools like webpack.Fix ng-handsontable not being able to be imported in webpack.
Please merge and publish a minor update to npm