Fix duplicate key error in FetchedJobs when job has multiple queue entries #419
+53
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a job has multiple entries in the
jobqueuetable (e.g., due to re-queuing or race conditions), the Hangfire dashboard crashes with:This occurs in
PostgreSqlMonitoringApi.FetchedJobsbecause the SQL query returns duplicate job IDs which are then passed toToDictionary().Solution
DISTINCTtoGetQueuedOrFetchedJobIdsto ensure unique job IDs are returnedDISTINCT ON (j."id")toFetchedJobsandEnqueuedJobsSQL queries as a safeguardTesting
Added integration test
FetchedJobs_WithDuplicateJobQueueEntries_DoesNotThrowthat:FetchedJobsvia the monitoring API