Fix LISTEN/NOTIFY connection self-healing #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When EnableLongPolling is enabled, the ListenForNotificationsAsync method only caught TaskCanceledException, causing all other exceptions (network timeouts, connection drops) to propagate up and kill the worker thread. This change adds self-healing reconnection logic that catches connection failures, reconnects after a 1 second backoff, and continues the loop. Fixes hangfire-postgres#410
nicolaj-hartmann
force-pushed
the
fix/listen-connection-self-healing
branch
from
c62568d to
ca736ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
EnableLongPollingis enabled, the LISTEN connection could die from network issues without recovery, causing workers to stop processing jobs while the server heartbeat continued.This adds automatic reconnection when the LISTEN connection fails.
Changes
Test
Added test that kills LISTEN connection via
pg_terminate_backendand verifies worker continues processing.Fixes #410