Add eccentric shearing sheet example simulation #840
Open
Lucinho21 wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a new folder in the examples folder called "shearing_sheet_eccentric" with its makefile and problem.c,
updated the boundary.c file with the eccentric boundary case,
and I've updated the output.c and rebound.h files to hold the Q_NL parameter.
I currently have the simulation running at the same particle density and surface density as the normal shearing sheet simulation, but with a box size of only 50m instead of 100m, I found this to run smoothly while having set gravity to basic and collisions to direct.