Skip to content

TRACE WB Coordinates#896

Merged
hannorein merged 33 commits into
hannorein:mainfrom
tigerchenlu98:wide_binary
Apr 29, 2026
Merged

TRACE WB Coordinates#896
hannorein merged 33 commits into
hannorein:mainfrom
tigerchenlu98:wide_binary

Conversation

@tigerchenlu98

Copy link
Copy Markdown
Collaborator

No description provided.

@tigerchenlu98

Copy link
Copy Markdown
Collaborator Author

Hey @hannorein, believe this should have incorporated all of our suggestions except the one about moving gravity terms from update_accelerations to integrator_trace -- don't think I understand what you mean there, could you elaborate?

@hannorein

Copy link
Copy Markdown
Owner

I can help move everything into the integrator_trace.c file at a later point. But maybe you can use REB_GRAVITY_TRACE for both coordinates? Just use an if statement in case REB_GRAVITY_TRACE. That would help down the road. Thanks.

@tigerchenlu98

tigerchenlu98 commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator Author

taken care of. Don't merge just yet though! A pesky bug with collisions w/ the central star that I'm trying to work out... will ping you when I've resolved it

@tigerchenlu98

Copy link
Copy Markdown
Collaborator Author

@hannorein put in some documentation! All the unit tests pass fine on my machine... not quite sure what's going on on the other architectures, it's all order unity issues.

@hannorein

Copy link
Copy Markdown
Owner

The speed test just needs to be relaxed as any timing is very inconsistent on the CI runner. I'm not sure about the others. It's strange that they fail on some architectures but not on others. Hopefully this isn't an indication of some sort of undefined behaviour...

@hannorein

Copy link
Copy Markdown
Owner

There are some merge conflicts left.

@tigerchenlu98

Copy link
Copy Markdown
Collaborator Author

done!

@hannorein hannorein merged commit eaa50c6 into hannorein:main Apr 29, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants