Fix: Zero-initialize particle in orbital_elements example to prevent undefined behavior#910
Open
yuanzui-cf wants to merge 1 commit into
Open
Conversation
…r in orbital elements example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
examples/orbital_elements/problem.c,struct reb_particle pis declared without initialization.While this happens to work on some systems due to zero-filled memory pages, on some machines (such as my MacBook M4) it leaves garbage values in stack memory, leading to incorrect relative orbit calculations.
Added
= {0}to properly zero-initialize the struct, preventing undefined behavior and matching the safe pattern used in other examples in this repository.