fs: NewNodeFS: actually handle opts = nil#596
Open
rfjakob wants to merge 2 commits intohanwen:masterfrom
Open
Conversation
Parts of the function did handle opts = nil, other parts did not. Handle it right at entry like fuse.NewServer, and document it. Change-Id: I265f1d7cb96a926879ca6769a0d08e613795b9cd
This adds a way to base your Options on the defaults *except* some setting. Also allows to deduplicate some code in go-fuse, which this change also does. I have only touched the exactly-equivalent cases here. Change-Id: I99dcd06c0239537c15bda2c27236d00c1a474cf0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-post of https://review.gerrithub.io/c/hanwen/go-fuse/+/1228929 for CI
Parts of the function did handle opts = nil, other parts did not.
Handle it right at entry like fuse.NewServer,
and document it.
Change-Id: I265f1d7cb96a926879ca6769a0d08e613795b9cd