Skip to content

Update eval_science_qa.py #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update eval_science_qa.py #1530

wants to merge 1 commit into from

Conversation

@jubinchheda
Copy link

@jubinchheda jubinchheda commented May 28, 2024

  • Use a set for split_indices and predictions to speed up lookup times.
  • Read files in a more efficient manner using with statements to ensure proper file handling.
  • Simplify the loop by combining conditions and removing redundant checks.
  • Use list comprehensions for filtering and counting.

@jubinchheda
Update eval_science_qa.py
1843325 
* Use a set for split_indices and predictions to speed up lookup times.
* Read files in a more efficient manner using with statements to ensure proper file handling.
* Simplify the loop by combining conditions and removing redundant checks.
* Use list comprehensions for filtering and counting.
@jubinchheda
Copy link
Author

jubinchheda commented May 31, 2024

Can we merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xufengduan xufengduan xufengduan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jubinchheda @xufengduan