fix: add test to show issue on isAsync #3085
Closed
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xballoy
commented
Jul 31, 2025
test/isAsync.js
Outdated
| }).isAsync()).to.be.true(); | ||
| }); | ||
|
|
||
| it('returns false for when without switch', () => { |
Contributor
Author
There was a problem hiding this comment.
Currently fails
Failed tests:
427) isAsync() returns true for any with async rules:
when.switch is not iterable
at internals.Base.isAsync (~/Projects/oss/joi/lib/base.js:485:41)
at internals.Base.isAsync (~/Projects/oss/joi/lib/types/keys.js:482:206)
at ~/Projects/oss/joi/test/isAsync.js:96:12
at Immediate.<anonymous> (~/Projects/oss/joi/node_modules/@hapi/lab/lib/runner.js:661:35)
at process.processImmediate (node:internal/timers:485:21)
Collaborator
|
Thanks, I indeed forgot to push some falsy tests towards the end. I pushed it directly on master, you can rebase your other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedicated PR for #3080 (comment)