Add support for The Last Chieftains in the fast parser#139
Open
Kjir wants to merge 1 commit intohappyleavesaoc:masterfrom
Open
Add support for The Last Chieftains in the fast parser#139Kjir wants to merge 1 commit intohappyleavesaoc:masterfrom
Kjir wants to merge 1 commit intohappyleavesaoc:masterfrom
Conversation
| "unknown_count"/If(lambda ctx: find_save_version(ctx) >= 66.3, Int32ul), | ||
| If(lambda ctx: find_save_version(ctx) >= 66.3, Bytes(12)), | ||
| If(lambda ctx: find_save_version(ctx) >= 66.3, Array(lambda ctx: ctx.unknown_count, Bytes(4))), | ||
| de_string, |
There was a problem hiding this comment.
There's 2 more de strings in 67.2 saves before this DE String.
Contributor
Author
There was a problem hiding this comment.
Before or after? I put them after, I don't think it's possible to know which one comes first unless we know what they contain.
Comment on lines
+179
to
+182
| If(lambda ctx: find_save_version(ctx) >= 67.2, Struct( | ||
| Int32ul, | ||
| Int32ul, | ||
| )), |
| Int32ul, | ||
| )), | ||
| "ver37"/If(lambda ctx: find_save_version(ctx) >= 37, Struct( | ||
| Int32ul, |
There was a problem hiding this comment.
This is a timestamp. Value seems to be always the same as at the one declared above in the struct.
Contributor
Author
There was a problem hiding this comment.
Yes this is a timestamp, I didn't change it here. I have it as a timestamp in my own Rust parser.
Make the necessary changes to support savegames from the Last Chieftains DLC. The full parser changes are not sufficient to make it work yet, more investigation is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the necessary changes to support savegames from the Last Chieftains DLC. The full parser changes are not sufficient to make it work yet, more investigation is needed.