Bidi frame spec#2975
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements frame detachment detection for the WebDriver BiDi protocol by adding support for checking whether frames have been closed/detached. The changes enable proper error handling when attempting to evaluate JavaScript in detached frames.
Key Changes:
- Added
Detachedproperty support for BiDi frames linked to the browsing context's closed state - Implemented detachment checks in the evaluation pipeline to throw appropriate errors
- Removed test expectations for now-passing frame, fixture, crash, device-request-prompt, diffstyle, and drag-and-drop test suites
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/PuppeteerSharp/Frame.cs | Made Detached property virtual to allow BiDi override |
| lib/PuppeteerSharp/Bidi/Core/BrowsingContext.cs | Added IsClosed property to track browsing context closure state |
| lib/PuppeteerSharp/Bidi/BidiRealm.cs | Added virtual ThrowIfDetached() method and its invocation in evaluation pipeline |
| lib/PuppeteerSharp/Bidi/BidiFrameRealm.cs | Implemented detachment check that throws exception for detached frames |
| lib/PuppeteerSharp/Bidi/BidiFrame.cs | Overrode Detached property to return browsing context closure state |
| lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json | Removed failing test expectations for multiple test suites now passing with BiDi implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kblok
commented
Oct 20, 2025
# Conflicts: # lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json # lib/PuppeteerSharp.Tests/ElementHandleTests/ContentFrameTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.