feat: add support for DevTools Issues#3402
Merged
Merged
Conversation
Implements puppeteer/puppeteer#14845 which adds support for DevTools issue events via the Audits CDP domain. - Add `Issue` class and `IssueEventArgs` for DevTools issue data - Add `IssuesEnabled` option to `LaunchOptions`, `ConnectOptions`, and `IBrowserOptions` - Add `Issue` event to `IPage` interface and `Page` abstract class - Add `IsIssuesEnabled()` to `Browser`, `CdpBrowser`, and `BidiBrowser` - Enable `Audits.enable` in `FrameManager.initialize` when issues are enabled - Handle `Audits.issueAdded` CDP events in `FrameManager` - Add CDP messaging types: `AuditsIssueAddedResponse`, `AuditsInspectorIssue` - Add tests for CSP violation issues and cross-origin iframe issues - Skip Issue event tests for BiDi in upstream test expectations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 6, 2026
This was referenced May 17, 2026
This was referenced Jun 4, 2026
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements changes from puppeteer/puppeteer#14845 which adds support for DevTools issue events.
Issueclass withCodeandDetailsproperties representing a DevTools issueIssueEventArgsevent arguments classIssuesEnabledoption (default:true) toLaunchOptions,ConnectOptions, andIBrowserOptionsto allow disabling issue monitoringIssueevent toIPageinterface andPageabstract classIsIssuesEnabled()toBrowserbase class,CdpBrowser, andBidiBrowserAudits.enableCDP command inFrameManager.InitializeAsyncwhen issues are enabledAudits.issueAddedCDP events inFrameManagerand emitPage.IssueeventsAuditsIssueAddedResponse,AuditsInspectorIssueTest plan
ShouldEmitIssueEventWhenCspViolationOccurs- passesShouldEmitIssueEventFromCrossOriginIframe- passesShouldBeAbleToConnectAndDisableIssues- passesBROWSER=CHROME PROTOCOL=cdp🤖 Generated with Claude Code