Use fontations for shape planning #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the ttf-parser code for script, langsys and feature lookup. GSUB/GPOS is now fully fontations.
Merged
rsheeter
reviewed
Jul 29, 2024
| .flatten() | ||
| } | ||
|
|
||
| fn script_index(&self, tag: hb_tag_t) -> Option<u16> { |
There was a problem hiding this comment.
The non-trivial methods (e.g. the ones that do more than things like feature_list or feature_variations) warrant comment, particularly wrt what they are meant to be used for. Imagine the reader is relatively new to both Rust and shaping.
rsheeter
reviewed
Jul 29, 2024
| } | ||
|
|
||
| impl crate::hb::ot_layout::LayoutTableExt for LayoutTable<'_> { | ||
| // hb_ot_layout_table_select_script |
There was a problem hiding this comment.
actually link to the hb fns here and below
rsheeter
reviewed
Jul 29, 2024
| None | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We've added lots of code that seems plausible to unit test and 0 unit tests. Seems sus.
rsheeter
approved these changes
Jul 29, 2024
|
Filed issue #13 to describe the process so we can get these merged before they go stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the ttf-parser code for script, langsys and feature lookup.
GSUB/GPOS is now fully fontations.