Add Docker support for Go tests with new Makefile target and Dockerfile #4921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Adds Docker-based support for running Go tests by introducing a dedicated Dockerfile and Makefile target.
Test.Dockerfile
to set up a container environment and runmake go-test
.docker-go-test
target in theMakefile
to run tests inside the built image.Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
docker-go-test
target to run Go tests via the Docker image.Comments suppressed due to low confidence (1)
Makefile:261
docker-go-test
target assumes the imagefrozen621/harmony-test
is already built, but there’s no build step or documentation. Consider adding adocker-build-test
target or instructions to build and tag that image.