Skip to content

Generic Binding Model update #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

wlegrand91
Copy link
Contributor

Added generic binding model implementation. Small changes to global_model.py to allow for some properties to be passed from the generic model, and new generic_binding_model.py file that implements the generic model. Also included are several new .ipynb notebooks and their corresponding model_spec.txt files that demonstrate a few examples. Will update with a readme shortly, and also I may have modified your example .ipynb and I can regenerate that over the weekend.

@wlegrand91
Copy link
Contributor Author

OK So I added a README in the model_spec folder (contains the model.txt files) with some basic info.

Two things:
1: For now it will only solve for C in terms of the usual variables, which for our system seems to be the only one that works anyway.
I would like to make it more general, i.e. solve for all or maybe one specific, but I expect that this requires a specific formulation of mass balance equations.

2: I'm realizing that I developed this on a linkage that doesn't have the parent functionality. I don't think they have any involvement with eachother, and can check this once I update my linkage to that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant