-
Notifications
You must be signed in to change notification settings - Fork 7
docs: added doc support for file-addition-trigger #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e1ee610
to
3386c25
Compare
3386c25
to
70e234d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the props don't quite match the component itself
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
….mdx Co-authored-by: Kevin Nagurski <[email protected]>
….mdx Co-authored-by: Kevin Nagurski <[email protected]>
….mdx Co-authored-by: Kevin Nagurski <[email protected]>
….mdx Co-authored-by: Kevin Nagurski <[email protected]>
….mdx Co-authored-by: Kevin Nagurski <[email protected]>
….mdx Co-authored-by: Kevin Nagurski <[email protected]>
….mdx Co-authored-by: Kevin Nagurski <[email protected]>
useTranslationStore={useTranslationStoreHook} | ||
pathNewFile="/new-file" | ||
pathUploadFiles="/upload-files" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a quick comment for each of the props to briefly explain them?
useTranslationStore={useTranslationStoreHook} | |
pathNewFile="/new-file" | |
pathUploadFiles="/upload-files" | |
useTranslationStore={useTranslationStoreHook} // something interesting | |
pathNewFile="/new-file" // something else | |
pathUploadFiles="/upload-files" // and some more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little inline explanation and we're good to go 👍🏻
closes #1239