Skip to content

docs: added doc support for file-addition-trigger #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

harish-viswa
Copy link
Contributor

closes #1239

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 200d96d
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67e52bec8a95a8000881b440
😎 Deploy Preview https://deploy-preview-1240--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 200d96d
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67e52becd0902600087e8419
😎 Deploy Preview https://deploy-preview-1240--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@harish-viswa harish-viswa force-pushed the docs/file-addition-trigger branch from e1ee610 to 3386c25 Compare March 12, 2025 16:05
@harish-viswa harish-viswa force-pushed the docs/file-addition-trigger branch from 3386c25 to 70e234d Compare March 12, 2025 16:13
Copy link
Collaborator

@knagurski knagurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the props don't quite match the component itself

Comment on lines +41 to +43
useTranslationStore={useTranslationStoreHook}
pathNewFile="/new-file"
pathUploadFiles="/upload-files"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a quick comment for each of the props to briefly explain them?

Suggested change
useTranslationStore={useTranslationStoreHook}
pathNewFile="/new-file"
pathUploadFiles="/upload-files"
useTranslationStore={useTranslationStoreHook} // something interesting
pathNewFile="/new-file" // something else
pathUploadFiles="/upload-files" // and some more

Copy link
Collaborator

@knagurski knagurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little inline explanation and we're good to go 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document File-additions-trigger component
2 participants