Skip to content

Tags page refactoring #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tags page refactoring #1358

wants to merge 1 commit into from

Conversation

hiderr
Copy link
Collaborator

@hiderr hiderr commented Apr 1, 2025

Summary

  1. The PR focuses on improving the user experience for tag management workflow on Repo -> Tags page.
  2. This PR introduces a new approach to toast notifications in the application by implementing a simplified hook-based solution for managing toasts.

Changes

1. Toast Notification System

  • Refactored the toast notification system by adding a new useToastNotification hook
  • Simplified the API to make toast management more straightforward
  • Removed complex implementation details like toast ID tracking in favor of a simpler state-based approach

2. Branch Management

  • Added a dedicated CreateBranchDialog component that uses the new toast notification system
  • Updated branch creation flow to show success notifications with branch name
  • Integrated branch creation dialog in relevant repository views

3. Tag Management

  • Refactored the tag management system to use the new branch selector components
  • Updated the tag creation dialog to work with the branch selector
  • Improved error handling for tag operations

4. UX Improvements

  • Added proper validation messages for branch and tag creation forms
  • Improved success feedback through toast notifications
  • Updated translations for branch/tag management operations

5. Code Organization

  • Removed duplicate code by centralizing branch and tag creation logic
  • Improved component reuse through new container patterns
  • Added proper typings for all new components and APIs

UI Changes Screenshots

Before:
image

After:
image

Before:
image

After:
image

Before:
image

After:
image

Before:
image

After:
image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit e70c8c8
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67f63ce46d89fb00080ff799
😎 Deploy Preview https://deploy-preview-1358--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit e70c8c8
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67f63ce408b49100082e399c
😎 Deploy Preview https://deploy-preview-1358--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiderr hiderr force-pushed the repo-tags branch 6 times, most recently from 8e4ace0 to cf3e8e0 Compare April 8, 2025 08:39
@3em 3em changed the title refactoring + fix to design Tags page refactoring Apr 8, 2025
@hiderr hiderr marked this pull request as ready for review April 9, 2025 09:24
@hiderr hiderr requested a review from knagurski as a code owner April 9, 2025 09:24
Copy link
Collaborator

@abhinavrastogi-harness abhinavrastogi-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please break this down into smaller PRs with more focused changes. this is untenable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants