Skip to content

fix features_enabled for k8s cc#1260

Open
rssnyder wants to merge 2 commits into
mainfrom
rssnyder-patch-2
Open

fix features_enabled for k8s cc#1260
rssnyder wants to merge 2 commits into
mainfrom
rssnyder-patch-2

Conversation

@rssnyder
Copy link
Copy Markdown
Contributor

@rssnyder rssnyder commented Jul 8, 2025

Title: Fix features_enabled for k8s cc connector

Summary:
Remove invalid features and reorder them.

Details:
BILLING is not a valid feature type for this connect. And visibility should be first as its the most common setting

Related Issues:
Reference any related issues or tickets

Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

  • Create the resource and execute terraform apply. (Verify the resource is created)
  • Execute terraform apply again without any changes. (Verify no changes should be done)
  • Update the resource and execute terraform apply. (Verify the resource updated successfully)
  • Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
  • Add again the resource and execute the terraform apply. (Verify the resource is created)
  • Verify the import the resource file is working fine.
  • In case of remote entity, Verify for both default and non default branch.

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

  • Code changes are well-documented.
  • Tests have been added/updated.
  • Changes have been tested locally.
  • Documentation has been updated.
PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

Copy link
Copy Markdown
Collaborator

@ritek01 ritek01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ritek01
Copy link
Copy Markdown
Collaborator

ritek01 commented Nov 7, 2025

Closing this pr due to non-active

@ritek01 ritek01 closed this Nov 7, 2025
@rssnyder
Copy link
Copy Markdown
Contributor Author

rssnyder commented Nov 7, 2025

@ritek01 its non-active because I was waiting to be merged. I see you approved, can we merge instead of closing??

@ritek01
Copy link
Copy Markdown
Collaborator

ritek01 commented Nov 8, 2025

Sure, We can merge this.

@ritek01 ritek01 reopened this Nov 8, 2025
@ritek01
Copy link
Copy Markdown
Collaborator

ritek01 commented Nov 8, 2025

Hey @rssnyder Could resolve the Conflict and let me know on updating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants