fix features_enabled for k8s cc#1260
Open
rssnyder wants to merge 2 commits into
Open
Conversation
Collaborator
|
Closing this pr due to non-active |
Contributor
Author
|
@ritek01 its non-active because I was waiting to be merged. I see you approved, can we merge instead of closing?? |
Collaborator
|
Sure, We can merge this. |
Collaborator
|
Hey @rssnyder Could resolve the Conflict and let me know on updating it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix
features_enabledfor k8s cc connectorSummary:
Remove invalid features and reorder them.
Details:
BILLING is not a valid feature type for this connect. And visibility should be first as its the most common setting
Related Issues:
Reference any related issues or tickets
Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.
Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:
PR Check triggers
trigger buildtrigger subcategoryfieldchecktrigger gitleaks