Skip to content

Reserve valve-controller and delphi-controller #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Poofjunior
Copy link

Reserve the 16 channel valve controller and the delphi controller derivative.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bruno-f-cruz
Copy link
Member

@Poofjunior Thanks for submitting!

Any chance you can split the PR to have one per board?
Additionally, while we do not enforce it, it would be great if you could:

As a side note, and this is more from the AIND side, I thought the valve-controller was not going to be deployed yet, since it was mainly designed as an "abstract" device implemented, for now, by the delphi-controller. Is this still true?

Finally, it would be nice to discuss how to keep track of these boards that share the hardware target. We have had some of these discussions in the past (e.g. Behavior board hw1.2 and 2.0, Input/Output expander, Cuttlefish and Hobgoblin) but it seems like this case keeps coming back over and over again. Maybe its time to change the way the WhoAmI works to allow people to spin off their own devices a bit more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants