-
Notifications
You must be signed in to change notification settings - Fork 6
Use swr for data fetching #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harryzcy
wants to merge
28
commits into
main
Choose a base branch
from
swr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
377a5a8
Introduce swr
harryzcy e72d7fa
Use swr to load emails
harryzcy 34f8cb9
Reorder states
harryzcy 0968ff6
Don't declare hook as async
harryzcy f83488c
Don't duplicate list emails logic
harryzcy cd5d027
Fix some lint issues
harryzcy c0ad6ec
Fix lint
harryzcy 3d94086
Load initial data with useEmails and remove useEffect
harryzcy b0d4733
Merge branch 'main' into swr
harryzcy df0ff20
Remove unused import
harryzcy 93a82ed
Use stable key for cache
harryzcy f10d2c7
Set key beforehand
harryzcy ac5c0b1
Seperate return type for use emails
harryzcy ae589b1
Revert "Seperate return type for use emails"
harryzcy 569d075
Fix typing
harryzcy 348bc96
Seperate return type for use emails
harryzcy d473a7a
Introduce useEmailsEffect
harryzcy e4c228a
Load data
harryzcy e037c19
Debug
harryzcy a3b2406
Set values
harryzcy 7ddf42e
Don't set next cursor
harryzcy 3421ddc
Remove unused count
harryzcy 3345b6f
Merge branch 'main' into swr
harryzcy 1f8b07d
Merge branch 'main' into swr
harryzcy 9bec690
Merge branch 'main' into swr
harryzcy 1035351
Merge branch 'main' into swr
harryzcy b464344
Merge branch 'main' into swr
harryzcy 0ad5316
Merge branch 'main' into swr
harryzcy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.