fix(ingest): reject malformed urls before shelling out to yt-dlp - #43
Merged
Merged
Conversation
fetch_video_transcript only checked that ingest() saw an http/https prefix before calling it, but the function itself never validated the scheme or host once it had the url. a file:// url or one missing a host would still build a full yt-dlp argv and hit subprocess.run. parse the url up front and bail out early if it isn't a real http(s) url with a host.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_video_transcript builds a yt-dlp argv from whatever url comes in, but only ingest() checked the http/https prefix before ever calling it. A file:// url or one missing a host still made it all the way to subprocess.run.
Added an upfront urlparse check that bails out with None unless the scheme is http/https and there's an actual host, plus tests for both cases.