chore: add CODEOWNERS - #11
Closed
harusharu wants to merge 11 commits into
Closed
Conversation
Brings in four skills from vercel/next.js that extend the repo skill set beyond the existing vercel-react-best-practices skill: - next-cache-components-adoption — guidance for adopting Next.js cache components (runtime semantics, read()/write(), dev-only validations, per-page decisions). - next-cache-components-optimizer — optimization patterns for cache components with real-app pattern references, red-test robustness guidance, and rig/test templates. - next-dev-loop — guidance for a faster inner development loop in Next.js projects. - next-partial-prefetching-adoption — guidance for adopting partial prefetching. These cover the cache-components workstream from the Next.js repository itself and give agents canonical references when working on this app's data caching and prefetching.
Adds the systematic-debugging skill from obra/superpowers, providing a structured methodology for tracing failures to their root cause and fixing them with defense in depth so they don't regress. Includes supporting references and tooling: - root-cause-tracing.md — tracing a symptom back to its root cause. - defense-in-depth.md — layering fixes so the issue stays fixed. - condition-based-waiting.md and a runnable TS example — waiting on conditions instead of fixed sleeps. - find-polluter.sh — helper to bisect which change broke a build/test. - test-academic.md and test-pressure-1..3.md — debugging exercises. Relevant to this repo's ffmpeg/transcode and stream-proxy debugging where symptoms often surface far from the failing call.
… skills Adds three skills from vercel-labs/agent-skills, complementing the existing vercel-react-best-practices skill the repo already uses: - vercel-composition-patterns — React composition rules: compound components, avoiding boolean props, children over render props, explicit variants, React 19 without forwardRef, state interfaces and state lifting. - vercel-react-view-transitions — the View Transitions API in React: CSS recipes, implementation patterns, and Next.js integration. - web-design-guidelines — concise visual design guidance for building better UIs. Each ships SKILL.md with supporting README/AGENTS.md, metadata, and rule/reference files. These are directly applicable to the current component work (Rail, Card, PlayerModal, Results) per the workflow in AGENTS.md.
Removes the golang-code-style skill (SKILL.md, eval fixtures, and references) from the repo skill set. The codebase is TypeScript/Next.js only and the skill guidance never applies to any file in the repository, so it was dead weight — the eval corpus and cross-references to samber/cc-skills-golang skills only make sense in a Go codebase. The repo skill set is now entirely React/Next.js and debugging focused, matching the actual code.
Deletes .npmrc and moves the approval for building msw into pnpm-workspace.yaml's allowBuilds block, alongside the existing ffmpeg-static entry. pnpm v10+ prefers onlyBuiltDependencies/allowBuilds in pnpm-workspace.yaml over the .npmrc only-built-dependencies key, and keeping both config locations would split the build-approval policy in two. This also avoids the .npmrc warning on every install and keeps a single source of truth for which packages may run postinstall scripts.
Rewrites the lockfile to match the updated repo skill set, pinning each skill to its upstream source, path, and computed hash: - Adds the four next.js skills (next-cache-components-adoption, next-cache-components-optimizer, next-dev-loop, next-partial-prefetching-adoption) from vercel/next.js, the systematic-debugging skill from obra/superpowers, and the vercel-composition-patterns, vercel-react-view-transitions, and web-design-guidelines skills from vercel-labs/agent-skills. - Removes the golang-code-style entry from samber/cc-skills-golang. - Keeps vercel-react-best-practices unchanged. The lockfile pins hashes so every checkout resolves the same skill content even if upstream moves.
A production build regenerated the generated type references back to the prod output (.next/types), reverting the dev type roots committed in the previous commit. The file is produced by Next and should not be edited by hand; commit the regenerated copy so typecheck stays in sync with the current build output.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR introduces repository ownership enforcement via a new .github/CODEOWNERS file, and also expands the repo’s agent-skill assets/config (skills lock updates plus a large set of .agents/skills/* additions) alongside a couple of workspace/type wiring tweaks.
Changes:
- Add
.github/CODEOWNERSwith a global owner rule (* @harusharu). - Update skill inventory/lock plus add multiple new skill documents under
.agents/skills/(and remove the previous Go style skill). - Adjust a few repo config files (
pnpm-workspace.yaml,next-env.d.ts,AGENTS.md) and remove.npmrc.
Reviewed changes
Copilot reviewed 60 out of 61 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| skills-lock.json | Replaces skill lock contents with a new set of skills (paths currently appear inconsistent with repo layout). |
| pnpm-workspace.yaml | Allows build scripts for msw in pnpm workspace configuration. |
| next-env.d.ts | Updates route/root param type import paths to .next/types/*. |
| AGENTS.md | Updates contributor guidance to always read .agents/skills/ at task start. |
| .npmrc | Removes previous pnpm/npm config entry related to msw build allowance. |
| .github/CODEOWNERS | Adds a CODEOWNERS rule assigning all paths to @harusharu. |
| .agents/skills/web-design-guidelines/SKILL.md | Adds a web design/a11y review skill document. |
| .agents/skills/vercel-react-view-transitions/SKILL.md | Adds React View Transitions skill core document. |
| .agents/skills/vercel-react-view-transitions/references/patterns.md | Adds View Transitions patterns reference. |
| .agents/skills/vercel-react-view-transitions/references/nextjs.md | Adds Next.js integration reference for View Transitions. |
| .agents/skills/vercel-react-view-transitions/references/implementation.md | Adds implementation workflow reference for View Transitions. |
| .agents/skills/vercel-react-view-transitions/references/css-recipes.md | Adds CSS recipes reference for View Transitions. |
| .agents/skills/vercel-react-view-transitions/README.md | Adds README for the View Transitions skill. |
| .agents/skills/vercel-react-view-transitions/metadata.json | Adds metadata for the View Transitions skill. |
| .agents/skills/vercel-composition-patterns/SKILL.md | Adds React composition patterns skill core document. |
| .agents/skills/vercel-composition-patterns/rules/state-lift-state.md | Adds “lift state” rule. |
| .agents/skills/vercel-composition-patterns/rules/state-decouple-implementation.md | Adds “decouple state from UI” rule. |
| .agents/skills/vercel-composition-patterns/rules/state-context-interface.md | Adds “generic context interface” rule. |
| .agents/skills/vercel-composition-patterns/rules/react19-no-forwardref.md | Adds React 19 API guidance rule. |
| .agents/skills/vercel-composition-patterns/rules/patterns-explicit-variants.md | Adds explicit variants rule. |
| .agents/skills/vercel-composition-patterns/rules/patterns-children-over-render-props.md | Adds children-over-render-props rule. |
| .agents/skills/vercel-composition-patterns/rules/architecture-compound-components.md | Adds compound components rule. |
| .agents/skills/vercel-composition-patterns/rules/architecture-avoid-boolean-props.md | Adds avoid-boolean-props rule. |
| .agents/skills/vercel-composition-patterns/rules/_template.md | Adds rule template. |
| .agents/skills/vercel-composition-patterns/rules/_sections.md | Adds section index/structure. |
| .agents/skills/vercel-composition-patterns/README.md | Adds README for composition patterns skill. |
| .agents/skills/vercel-composition-patterns/metadata.json | Adds metadata for composition patterns skill. |
| .agents/skills/systematic-debugging/test-pressure-3.md | Adds pressure test scenario doc. |
| .agents/skills/systematic-debugging/test-pressure-2.md | Adds pressure test scenario doc. |
| .agents/skills/systematic-debugging/test-pressure-1.md | Adds pressure test scenario doc. |
| .agents/skills/systematic-debugging/test-academic.md | Adds academic test prompt doc. |
| .agents/skills/systematic-debugging/SKILL.md | Adds systematic debugging skill core document. |
| .agents/skills/systematic-debugging/root-cause-tracing.md | Adds root-cause tracing reference. |
| .agents/skills/systematic-debugging/find-polluter.sh | Adds test polluter-finding helper script. |
| .agents/skills/systematic-debugging/defense-in-depth.md | Adds defense-in-depth reference. |
| .agents/skills/systematic-debugging/CREATION-LOG.md | Adds creation log for the debugging skill. |
| .agents/skills/systematic-debugging/condition-based-waiting.md | Adds condition-based waiting reference. |
| .agents/skills/systematic-debugging/condition-based-waiting-example.ts | Adds example implementation for condition-based waiting. |
| .agents/skills/next-partial-prefetching-adoption/SKILL.md | Adds Next.js partial prefetching adoption skill. |
| .agents/skills/next-dev-loop/SKILL.md | Adds Next.js dev verification loop skill. |
| .agents/skills/next-cache-components-optimizer/test-template.md | Adds Playwright instant() test template reference. |
| .agents/skills/next-cache-components-optimizer/rig-template.md | Adds rig discovery template reference. |
| .agents/skills/next-cache-components-optimizer/reference/red-test-robustness.md | Adds RED-test robustness reference. |
| .agents/skills/next-cache-components-optimizer/reference/real-app-patterns.md | Adds real-app patterns reference. |
| .agents/skills/next-cache-components-optimizer/reference/patterns.md | Adds optimizer patterns reference. |
| .agents/skills/next-cache-components-adoption/references/per-page-decisions.md | Adds per-page decision reference for cache-components adoption. |
| .agents/skills/next-cache-components-adoption/references/dev-only-validations.md | Adds dev-only validation sweep reference. |
| .agents/skills/find-skills/SKILL.md | Adds “find skills” skill document. |
| .agents/skills/caveman/SKILL.md | Adds caveman compression skill core document. |
| .agents/skills/caveman/README.md | Adds README for caveman skill. |
| .agents/skills/caveman-review/SKILL.md | Adds caveman PR review style skill. |
| .agents/skills/caveman-review/README.md | Adds README for caveman-review skill. |
| .agents/skills/caveman-commit/SKILL.md | Adds caveman commit message skill. |
| .agents/skills/caveman-commit/README.md | Adds README for caveman-commit skill. |
| .agents/skills/golang-code-style/SKILL.md | Removes Go code style skill document. |
| .agents/skills/golang-code-style/references/details.md | Removes Go code style reference details doc. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1 @@ | |||
| * @harusharu | |||
Comment on lines
+4
to
+8
| "caveman": { | ||
| "source": "juliusbrussee/caveman", | ||
| "sourceType": "github", | ||
| "skillPath": "skills/golang-code-style/SKILL.md", | ||
| "computedHash": "1c949d9721fac34faf39e640a08c9f17b6449a64183824ac99d2e3785b1fef57" | ||
| "skillPath": "skills/caveman/SKILL.md", | ||
| "computedHash": "48646eeec87b27067502d8bd450484faf08af588df783706b1571ee72f2d918c" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds .github/CODEOWNERS so PRs require CODEOWNER approval.