Dedup summary-covered detail bullets + regenerate stale docs#121
Merged
Conversation
Extend summary_covered_generic_verb so a generic detail bullet is suppressed when the node summary already states the edit, for reorder_columns (binoc.column-reorder) and serialization_change (binoc.serialization-change), matching the existing rename_column case. Updates the six affected test-vector changelog snapshots. Also regenerates committed docs that were left stale on main: the ADR nav block and index status line for the vintage-audience ADR (merged in #118 without a docs run), and the tutorial / test-vectors gallery, which now reflect both the merged vintage vector and the dedup'd rendering. Brings 'just docs' (git diff --exit-code -- docs/) and the full test suite back to green.
The rusqlite 0.39 -> 0.40 bump pulls libsqlite3-sys 0.38, whose build script uses cfg_select!, stabilized in Rust 1.95, so the workspace no longer builds on the previous 1.88 MSRV. Per the MSRV policy ADR, this is an intentional, called-out bump: move rust-version and the MSRV CI job to 1.95.0 together, with an addendum recording the decision. Verified: full workspace compiles on the 1.95.0 toolchain.
The previous tutorial.md regeneration ran against a stale binoc-python wheel: 'uvx --with ./binoc-python' keys its build cache on the binoc-python/ directory, so edits to the Rust workspace (and prior refactors) never invalidated it, leaving the rendered changelog blocks out of date (e.g. missing '/>' decompose boundaries and detail bullets). Regenerated with UV_NO_CACHE=1 so the output matches the committed source and CI's fresh build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update renderer to skip generic fallback change reports when they are handled specially during output. Six affected test-vector changelog snapshots updated.
MSRV 1.88 → 1.95 — the merged
rusqlite0.39 → 0.40 bump pullslibsqlite3-sys0.38, whose build script usescfg_select!(stabilized in Rust 1.95), so the workspace no longer builds on 1.88. Per the MSRV policy ADR, this is a good time to manually bump MSRV.Docs regeneration —
just docshad drifted onmainbecause of other PRs I just merged; update.