feat: add rancher integration pipeline by FrankYang0529 · Pull Request #1033 · harvester/harvester-installer

FrankYang0529 · 2025-04-17T06:20:29Z

Problem:

Solution:

Related Issue(s):

harvester/harvester#7889

Test plan:

Additional documentation or context

Copilot

Pull Request Overview

This PR introduces a new GitHub Actions workflow for Rancher integration that automates version patching, building Harvester artifacts, and running integration tests.

Adds a workflow to patch RKE2 and Rancher versions, build artifacts, and deploy/test clusters.
Includes steps for cloning ipxe-examples, performing cluster setup, running tests, and collecting logs.

innobead · 2025-04-25T03:10:33Z

+        working-directory: ${{ steps.ipxe.outputs.VAGRANT_HOME }}
+        run: |
+          vagrant destroy -f
+      - name: Remove OVMF.fd line if needed


What's the purpose for this?

I copy this from

harvester-installer/.github/workflows/vagrant-install.yaml

Lines 47 to 53 in 6973fcd

- name: Remove OVMF.fd line if needed

working-directory: ${{ steps.ipxe.outputs.VAGRANT_HOME }}

run: |

if [ ! -f /usr/share/qemu/OVMF.fd ]; then

echo "Remove libvirt loader: can't find UEFI firmware"

sed 's/libvirt.loader.*/#libvirt.loader = /' Vagrantfile

fi

. @bk201 do you know why we need this in CI? Does it avoid UEFI firmware not found error?

If the OVMF file is present in the system, the VM will run in UEFI mode, otherwise, it will run in legacy BIOS mode. Not every runner has the file presented.

If some snippets are resuable, suggest creating util scripts or workflows, then share them with each other. In addition, please also add comments to clarify the purpose, or prefer making the step name self-explantory. It will be good for understanding.

innobead

Can we make a reusable workflow which can be used in both workflow to reduce duplicated implementation here? Basically, have a job running the reusbale workflow, then start the different steps in another job.

innobead · 2025-04-25T03:13:41Z

+        working-directory: ./ci/terraform
+        run: |
+          ./cleanup_test_files.sh
+      - name: Testing existing files


Check files exist on provisioned hosts

nit: The name is quite general, can we make them specific? What files should exist. check_files.sh is also too common.

Since check_files.sh is used in other workflow, I will update the naming in the next PR.

innobead · 2025-04-25T03:21:21Z

+          ./test_terraform_vm.sh ${{ steps.ipxe.outputs.VAGRANT_HOME }}/settings.yml
+
+      - name: Check Rancher System Agent
+        run: |


Should we move this just after Setup cluster?

I prefer to keep it after terraform check. If it checks rancher-system-agent just after setup cluster, the cluster may not be ready.

I see, then it can be part of tests.

innobead · 2025-04-25T03:41:55Z

The ultimate goal is to automatically detect the versions of Rancher and RKE2, and then run these workflows.

There are a few things we need to improve later.

Create a matrix strategy outlining which versions to run in the workflow. For instance: Harvester 1.5/Rancher 2.11/RKE2 1.32, we only need to execute pipelines for supported branches and the head. Currently, these are head/1.6, 1.5, 1.4, and 1.3. To conserve resources, we will only run head, n, and n-1, which means head, 1.5, and 1.4.
Schedule a daily cron job to check for any new releases (just released on the day) of Rancher or RKE2, and run the testing pipeline as needed. You may require an additional step/job initially to determine them. If no new releases are available, there's no need to execute anything.
W/ above improvements, still ensure the capability to run manually by entering upstream versions

innobead

Just a few minor feedback. After resolving them, we can merge this first, so you can verify and fine-tune this later.

innobead · 2025-06-18T09:24:37Z

+      - name: Create new-version.yaml
+        working-directory: ./ci/upgrade
+        run: |
+          ./create_upgrade_file.sh


This should be create_version_file.sh instead?

BTW, can we simplify the upgrade operation as follows? When creating a new version or upgrade, apply it directly.

- name: Start file server run: | python3 -m http.server 8000 --bind 0.0.0.0 & - name: Create the upgrade version working-directory: ./ci/upgrade run: | ./create_version.sh - name: Create the upgrade working-directory: ./ci/upgrade run: | ./create_upgrade.sh

innobead · 2025-06-18T09:28:15Z

+
+      - name: Check Rancher System Agent
+        run: |
+          for i in 0 1 2; do


Can we move this to check_rancher_system_agent.sh? I would like to move all checks and tests under the terraform folder to make them consistent as the existing test scripts like test_terraform_vm.sh.

innobead · 2025-06-18T09:28:35Z

+
+      - name: Test Login
+        run: |
+          node0_ip=$(yq e ".harvester_network_config.cluster[0].ip" ${{ steps.ipxe.outputs.VAGRANT_HOME }}/settings.yml)


ditto, move this to check_login.sh

innobead · 2025-06-18T09:28:46Z

+            exit 1
+          fi
+
+      - name: Test RKE2 cert rotation


check_rke2_cert_rotation.sh

Signed-off-by: PoAn Yang <poan.yang@suse.com>

Copilot AI review requested due to automatic review settings April 17, 2025 06:20

Copilot AI reviewed Apr 17, 2025

View reviewed changes

Comment thread .github/workflows/rancher-integration.yaml Outdated

Comment thread .github/workflows/rancher-integration.yaml Outdated

Comment thread .github/workflows/rancher-integration.yaml Outdated

FrankYang0529 force-pushed the HARV-7889 branch 5 times, most recently from 0835b17 to 072422c Compare April 23, 2025 08:48

innobead requested a review from Vicente-Cheng April 23, 2025 09:39

innobead reviewed Apr 25, 2025

View reviewed changes

Comment thread .github/workflows/rancher-integration.yaml Outdated

innobead reviewed Apr 25, 2025

View reviewed changes

Comment thread .github/workflows/rancher-integration.yaml

innobead reviewed Apr 25, 2025

View reviewed changes

innobead requested changes Apr 25, 2025

View reviewed changes

starbops reviewed Apr 25, 2025

View reviewed changes

Comment thread ci/upgrade/create_upgrade_file.sh

FrankYang0529 force-pushed the HARV-7889 branch 2 times, most recently from 12f7b4a to 851bacf Compare April 25, 2025 05:32

FrankYang0529 requested review from bk201, innobead and starbops April 25, 2025 07:31

innobead requested changes Jun 18, 2025

View reviewed changes

FrankYang0529 added 4 commits June 19, 2025 15:19

feat: add rancher integration pipeline

85d0d6f

Signed-off-by: PoAn Yang <poan.yang@suse.com>

feat: add rancher upgrade integration pipeline

a4dbcd9

Signed-off-by: PoAn Yang <poan.yang@suse.com>

fix error input

96453d3

Signed-off-by: PoAn Yang <poan.yang@suse.com>

add comment

07dd7d2

Signed-off-by: PoAn Yang <poan.yang@suse.com>

FrankYang0529 force-pushed the HARV-7889 branch from 851bacf to 07dd7d2 Compare June 19, 2025 07:23

	- name: Remove OVMF.fd line if needed
	working-directory: ${{ steps.ipxe.outputs.VAGRANT_HOME }}
	run: \|
	if [ ! -f /usr/share/qemu/OVMF.fd ]; then
	echo "Remove libvirt loader: can't find UEFI firmware"
	sed 's/libvirt.loader.*/#libvirt.loader = /' Vagrantfile
	fi

Conversation

FrankYang0529 commented Apr 17, 2025

Problem:

Solution:

Related Issue(s):

Test plan:

Additional documentation or context

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

innobead left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

innobead commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

innobead left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

innobead commented Apr 25, 2025 •

edited

Loading