feat: add cpu model selection #702
Open
+189
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
reviewed
Feb 2, 2026
pkg/harvester/l10n/en-us.yaml
Outdated
| osType: OS Type | ||
| cpuModel: | ||
| label: CPU Model | ||
| placeholder: Select a CPU model (optional) |
Collaborator
There was a problem hiding this comment.
We can remove (optional) since all required fields have red star.
a110605
reviewed
Feb 2, 2026
|
|
||
| // Add None option at the beginning | ||
| options.push({ | ||
| label: this.t('harvester.virtualMachine.cpuModel.none'), |
Collaborator
There was a problem hiding this comment.
[Can Discuss] how do you think we let None (value is '') as the defult value ? Any concern from backend side?
Contributor
Author
There was a problem hiding this comment.
Good Idea. I used Default (value is '').
Signed-off-by: Jack Yu <[email protected]>
ihcsim
approved these changes
Feb 11, 2026
ibrokethecloud
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We ended up using config map. It should be the final decision for this case. But, anyway, the GUI shouldn't have too many changes. The GUI changes include virtualmachine and virutalmachinetemplateversion.
PR Checklists
Related Issue
GUI: harvester/harvester#6863, harvester/harvester#9745
Original Issue: harvester/harvester#3015
Backend: harvester/harvester#9522
Test screenshot or video
demo-01.mov