Skip to content

Conversation

@ibrokethecloud
Copy link

Summary

In a scenario when Harvester seeder is enabled, and user performs an out of band power operation, seeder does not reconcile with the underlying hardware.

It currently uses power action request and state to identify if underlying host is power off / on.

Harvester UI reports the node as Off though the underlying kubelet and workloads may be running.

This can lead to a scenario, where a machine may have been power on out of band from Harvester seeder integration

image

PR: harvester/seeder#81 adds a new field in inventory status called machinePowerState which reconciles underlying hardware power state directly from the hardware.

The UI PR makes the corresponding change in isStopped and isStarted method to leverage this field rather than the current combination of powerActionRequested and actionStatus

Post this change, if a machine is poweredOn out of band from Harvester seeder, the machine power state is correctly reflected in the UI

image

PR Checklists

  • Are backend engineers aware of UI changes ?
    • Yes, the backend owner is:

Related Issue

harvester/harvester#5780
harvester/harvester#9749

Test screenshot or video

Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants