feat: remove old format pci device name checking#889
Open
Yu-Jack wants to merge 1 commit into
Open
Conversation
when implementing the first version pci device passthrough, we didn't have our own device plugin, then resource name was changed after upgrade. Right now, we already have our own device plugin, which we can control resource name by our ourselves. So, we can remove old mechanism. Signed-off-by: Jack Yu <jack.yu@suse.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy PCI device naming convention check from the VM PCI devices editor, since Harvester now has its own device plugin that controls resource names directly. The deprecated warning UI and associated translations are removed, and the template is simplified accordingly.
Changes:
- Drop
oldFormatDevicesstate, computed HTML helper, and the related warning Banner fromVirtualMachinePciDevices/index.vue. - Simplify the
mountedhook to always populateselectedDeviceswithout the old-format branch. - Remove the
harvester.pci.oldFormatDevicestranslation block fromen-us.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachinePciDevices/index.vue | Removes old-format device detection logic, state, computed, and Banner; restructures template. |
| pkg/harvester/l10n/en-us.yaml | Removes the now-unused oldFormatDevices translation strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when implementing the first version pci device passthrough, we didn't have our own device plugin, then resource name was changed after upgrade.
Right now, we already have our own device plugin, which we can control resource name by our ourselves. So, we can remove old mechanism.
Summary
PR Checklists
Related Issue
backend: harvester/pcidevices#191
original issue: harvester/harvester#6724
Test screenshot or video
Before:
After: