hep: customize support bundle file name [skip ci] #9804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an enhancement proposal for customizing support bundle file names in Harvester, addressing the need for more identifiable naming when managing multiple clusters.
Key Changes:
- Adds an enhancement document proposing a
DisplayNamefield for support bundle CRs - Defines a new naming template format:
supportbundle_{display_name}_{time}when a display name is provided - Proposes frontend changes to accept an optional display name input
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jack Yu <[email protected]>
Yu-Jack
changed the title
Contributor
Author
|
Actually, I don't think we need this HEP ... Just rename the tarball. Otherwise, we use cluster name to rename it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In original issue, it mentions we can use cluster name to do that. But, we don't have it and actually we have an adding cluster name issue before (#4738).
For this case, I think we just need a display name instead of cluster name.
Solution:
Related Issue(s):
#9257
Test plan:
Additional documentation or context