settings: decrease the default storage overcommit to 100%

[Vicente-Cheng]

- To align with default configuration of Longhorn
- Also, lower the out-of-space risk

Problem:

We should align the storage overcommit with Longhorn's default settings

Solution:

Align the storage overcommit

Related Issue(s):

#9954

Test plan:

1. Create Harvester cluster
2. Ensure the default storage overcommit was 100% (before was 200%)

Additional documentation or context

[Copilot]

Pull request overview

This pull request aligns Harvester's default storage overcommit configuration with Longhorn's default value by decreasing it from 200% to 100%. This change reduces the risk of out-of-space issues while maintaining consistency with upstream Longhorn configuration.

Changes:

• Decreased default storage overcommit from 200% to 100% in the settings
• Updated comment to reflect alignment with Longhorn's default setting

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pkg/settings/settings.go	Changed default storage overcommit value from 200 to 100 in OvercommitConfig setting
pkg/controller/master/setting/handler.go	Updated comment to reflect that storage overcommit is now aligned with Longhorn's default

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment is incomplete and unclear. Consider revising to make it a complete, grammatically correct sentence that better explains the purpose. For example: "The storage overcommit setting is now aligned with Longhorn's default value and needs to be synced on bootstrap" or "Sync overcommit config on bootstrap. Storage overcommit is now aligned with Longhorn's default setting."

[w13915984028]

LGTM, thanks.

Let's also add this change to release note and document, reminder user to review and update this config after upgrading to latest version if necessary, Harvester does not revert existing values automatically,.

[starbops]

As discussed with @Vicente-Cheng offline, we might need to handle the upgrade path carefully, as it will lower the default value once the new Harvester version goes live. Thanks @w13915984028 for raising the concern.