feat: Debug Mode with ipxe-examples Vagrant #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great idea |
m-ildefons
previously approved these changes
Jun 30, 2025
Member
m-ildefons
left a comment
m-ildefons
left a comment
There was a problem hiding this comment.
This is cool.
I have a few small nits that would improve readability and conciseness a bit, but consider them to be optional.
* allow for debug mode when provisioning Signed-off-by: Mike Russell <[email protected]>
irishgordo
force-pushed
the
feat/debug-mode
branch
from
0392ace to
86672aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Debugging
Solution:
Enable debugging via settings flag, for both Ansible & Vagrant elements
Related Issue(s):
N/A
Test plan:
Test provisioning succeeds with debug enabled & disabled.
With debugging enabled, should see a lot more underlying logs fired off in standard out in the terminal.
Additional documentation or context
N/A, self documented in comments of settings.yml