feat: remove useless steps #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
HARV-9766
branch
from
9abaef4 to
492bdf0
Compare
starbops
reviewed
Jan 20, 2026
Comment on lines
-126
to
-128
| if err := p.addInstruction(rancher.ToUpdateClientSecretInstruction(cfg.RancherInstallerImage, cfg.SystemDefaultRegistry, k8sVersion)); err != nil { | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
Since this will be removed, we can also remove the respective subcommand at cmd/rancherd/updateclientsecret/update.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem & Solution:
harvester/harvester#9766
Related Issue(s):
harvester/harvester#9766
Test plan:
Create a 3-node Harvester cluster successfully.
Additional documentation or context